D8937: rust: enable on macOS

Submitter	phabricator
Date	Aug. 19, 2020, 3:52 p.m.
Message ID	<differential-rev-PHID-DREV-ezlhyjxuczqqhrdjbvfd-req@mercurial-scm.org>
Download	mbox \| patch
Permalink	/patch/47037/
State	Superseded
Headers	show Return-Path: <mercurial-devel-bounces@mercurial-scm.org> Date: Wed, 19 Aug 2020 15:52:49 +0000 To: Phabricator <phabricator@mercurial-scm.org> From: "danchr (Dan Villiom Podlaski Christiansen)" <phabricator@mercurial-scm.org> Subject: D8937: rust: enable on macOS Message-ID: <differential-rev-PHID-DREV-ezlhyjxuczqqhrdjbvfd-req@mercurial-scm.org> Precedence: bulk Thread-Topic: PHID-DREV-ezlhyjxuczqqhrdjbvfd Thread-Index: YmYzZWQzY2YxM2Q3NzgzOTE2YmYyYWZmZTZj MIME-Version: 1.0 Cc: mercurial-devel@mercurial-scm.org Reply-To: "danchr \(Dan Villiom Podlaski Christiansen\)" <phabricator+D8937+public+65a2e2468ecd2325@mercurial-scm.org> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: mercurial-devel-bounces@mercurial-scm.org Sender: "Mercurial-devel" <mercurial-devel-bounces@mercurial-scm.org>

Comments

phabricator - Aug. 19, 2020, 3:52 p.m.

danchr created this revision.
Herald added a reviewer: hg-reviewers.
Herald added a subscriber: mercurial-patches.

REVISION SUMMARY
  AFAICT this works quite well, apart from one issue related to the
  dirstate mishandling removed files. I'm not entirely sure why, but
  disabling the code makes all the high-level tests pass.
  
  Most of the Rust tests pass as well, apart from one PathAuditor test.

REPOSITORY
  rHG Mercurial

BRANCH
  default

REVISION DETAIL
  https://phab.mercurial-scm.org/D8937

AFFECTED FILES
  rust/hg-core/src/dirstate/dirstate_map.rs
  rust/hg-core/src/lib.rs

CHANGE DETAILS




To: danchr, #hg-reviewers
Cc: mercurial-patches, mercurial-devel

Patch

diff --git a/rust/hg-core/src/lib.rs b/rust/hg-core/src/lib.rs
--- a/rust/hg-core/src/lib.rs
+++ b/rust/hg-core/src/lib.rs
@@ -26,11 +26,10 @@ 
 pub mod operations;
 pub mod utils;
 
-// Remove this to see (potential) non-artificial compile failures. MacOS
-// *should* compile, but fail to compile tests for example as of 2020-03-06
-#[cfg(not(target_os = "linux"))]
+// Remove this to see (potential) non-artificial compile failures.
+#[cfg(not(any(target_os = "linux", target_os = "macos")))]
 compile_error!(
-    "`hg-core` has only been tested on Linux and will most \
+    "`hg-core` has only been tested on Linux and macOS and will most \
      likely not behave correctly on other platforms."
 );
 
diff --git a/rust/hg-core/src/dirstate/dirstate_map.rs b/rust/hg-core/src/dirstate/dirstate_map.rs
--- a/rust/hg-core/src/dirstate/dirstate_map.rs
+++ b/rust/hg-core/src/dirstate/dirstate_map.rs
@@ -396,6 +396,7 @@ 
             return file_fold_map;
         }
         let mut new_file_fold_map = FileFoldMap::default();
+        #[cfg(not(target_os="macos"))]
         for (filename, DirstateEntry { state, .. }) in self.state_map.borrow()
         {
             if *state == EntryState::Removed {

Patchwork D8937: rust: enable on macOS

Comments

Patch