Patchwork D8857: packaging: delete unnecessary updating of `dirs` list

login
register
mail settings
Submitter phabricator
Date July 31, 2020, 11:59 p.m.
Message ID <differential-rev-PHID-DREV-xppyrnchw456olrarqht-req@mercurial-scm.org>
Download mbox | patch
Permalink /patch/46954/
State Superseded
Headers show

Comments

phabricator - July 31, 2020, 11:59 p.m.
martinvonz created this revision.
Herald added a reviewer: hg-reviewers.
Herald added a subscriber: mercurial-patches.

REVISION SUMMARY
  The `dirs` list is not used and it seems it also wasn't used when this
  code was added in 395b0e132836 <https://phab.mercurial-scm.org/rHG395b0e132836995e5775f6e54af55338035ec49a> (Don't copy hidden files/directories
  during `setup.py install`, 2009-07-14).

REPOSITORY
  rHG Mercurial

BRANCH
  default

REVISION DETAIL
  https://phab.mercurial-scm.org/D8857

AFFECTED FILES
  setup.py

CHANGE DETAILS




To: martinvonz, #hg-reviewers
Cc: mercurial-patches, mercurial-devel

Patch

diff --git a/setup.py b/setup.py
--- a/setup.py
+++ b/setup.py
@@ -1639,7 +1639,6 @@ 
 for root in ('templates',):
     for curdir, dirs, files in os.walk(os.path.join('mercurial', root)):
         curdir = curdir.split(os.sep, 1)[1]
-        dirs[:] = filter(ordinarypath, dirs)
         for f in filter(ordinarypath, files):
             f = os.path.join(curdir, f)
             packagedata['mercurial'].append(f)