Patchwork D8851: phabricator: demonstrate debugcallconduit being broken without --test-vcr

login
register
mail settings
Submitter phabricator
Date July 30, 2020, 4:03 p.m.
Message ID <differential-rev-PHID-DREV-24gsfstu3xix7mzx5g4j-req@mercurial-scm.org>
Download mbox | patch
Permalink /patch/46949/
State Superseded
Headers show

Comments

phabricator - July 30, 2020, 4:03 p.m.
Kwan created this revision.
Herald added a reviewer: hg-reviewers.
Herald added a subscriber: mercurial-patches.

REVISION SUMMARY
  This was accidentally broken by 11592ce6a711 <https://phab.mercurial-scm.org/rHG11592ce6a7119a5ea2779e914ff21833171ba6f8> / D8525 <https://phab.mercurial-scm.org/D8525>

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D8851

AFFECTED FILES
  tests/test-phabricator.t

CHANGE DETAILS




To: Kwan, #hg-reviewers
Cc: mercurial-patches, mercurial-devel

Patch

diff --git a/tests/test-phabricator.t b/tests/test-phabricator.t
--- a/tests/test-phabricator.t
+++ b/tests/test-phabricator.t
@@ -24,6 +24,18 @@ 
   > EOF
   $ VCR="$TESTDIR/phabricator"
 
+BROKEN: debugcallconduit fails without --test-vcr:
+  $ echo '{}' | HGRCSKIPREPO= hg debugcallconduit 'conduit.ping'
+  hg debugcallconduit: invalid arguments
+  hg debugcallconduit METHOD
+  
+  call Conduit API
+  
+  options:
+  
+  (use 'hg debugcallconduit -h' to show more help)
+  [255]
+
 Error is handled reasonably. We override the phabtoken here so that
 when you're developing changes to phabricator.py you can edit the
 above config and have a real token in the test but not have to edit