Patchwork tests: make one of 'worker process exited' line option in test-chg.t

login
register
mail settings
Submitter Pulkit Goyal
Date July 22, 2020, 9:28 a.m.
Message ID <555480075e6305f85f97.1595410138@workspace>
Download mbox | patch
Permalink /patch/46833/
State Accepted
Headers show

Comments

Pulkit Goyal - July 22, 2020, 9:28 a.m.
# HG changeset patch
# User Pulkit Goyal <7895pulkit@gmail.com>
# Date 1595410129 -19800
#      Wed Jul 22 14:58:49 2020 +0530
# Node ID 555480075e6305f85f9738bc1b52a00f83032f15
# Parent  55464c0b3a89c52672e1fe816fddf4e391a51768
# EXP-Topic chg-test
tests: make one of 'worker process exited' line option in test-chg.t

I investigated and it seems like under high load, the child process is already
there and no new fork was created. Hence the process was not closed.
Pierre-Yves David - July 22, 2020, 10:20 a.m.
Could we force the child process to terminate before starting that 
section of the test ?

On 7/22/20 11:28 AM, Pulkit Goyal wrote:
> # HG changeset patch
> # User Pulkit Goyal <7895pulkit@gmail.com>
> # Date 1595410129 -19800
> #      Wed Jul 22 14:58:49 2020 +0530
> # Node ID 555480075e6305f85f9738bc1b52a00f83032f15
> # Parent  55464c0b3a89c52672e1fe816fddf4e391a51768
> # EXP-Topic chg-test
> tests: make one of 'worker process exited' line option in test-chg.t
> 
> I investigated and it seems like under high load, the child process is already
> there and no new fork was created. Hence the process was not closed.
> 
> diff --git a/tests/test-chg.t b/tests/test-chg.t
> --- a/tests/test-chg.t
> +++ b/tests/test-chg.t
> @@ -366,7 +366,7 @@ check server log:
>   
>     $ cat log/server.log | filterlog
>     YYYY/MM/DD HH:MM:SS (PID)> worker process exited (pid=...)
> -  YYYY/MM/DD HH:MM:SS (PID)> worker process exited (pid=...)
> +  YYYY/MM/DD HH:MM:SS (PID)> worker process exited (pid=...) (?)
>     YYYY/MM/DD HH:MM:SS (PID)> init cached
>     YYYY/MM/DD HH:MM:SS (PID)> id -R cached
>     YYYY/MM/DD HH:MM:SS (PID)> loaded repo into cache: $TESTTMP/cached (in  ...s)
> 
> _______________________________________________
> Mercurial-devel mailing list
> Mercurial-devel@mercurial-scm.org
> https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
>
Yuya Nishihara - July 22, 2020, 10:23 a.m.
On Wed, 22 Jul 2020 14:58:58 +0530, Pulkit Goyal wrote:
> # HG changeset patch
> # User Pulkit Goyal <7895pulkit@gmail.com>
> # Date 1595410129 -19800
> #      Wed Jul 22 14:58:49 2020 +0530
> # Node ID 555480075e6305f85f9738bc1b52a00f83032f15
> # Parent  55464c0b3a89c52672e1fe816fddf4e391a51768
> # EXP-Topic chg-test
> tests: make one of 'worker process exited' line option in test-chg.t

Queued for stable, thanks.

Patch

diff --git a/tests/test-chg.t b/tests/test-chg.t
--- a/tests/test-chg.t
+++ b/tests/test-chg.t
@@ -366,7 +366,7 @@  check server log:
 
   $ cat log/server.log | filterlog
   YYYY/MM/DD HH:MM:SS (PID)> worker process exited (pid=...)
-  YYYY/MM/DD HH:MM:SS (PID)> worker process exited (pid=...)
+  YYYY/MM/DD HH:MM:SS (PID)> worker process exited (pid=...) (?)
   YYYY/MM/DD HH:MM:SS (PID)> init cached
   YYYY/MM/DD HH:MM:SS (PID)> id -R cached
   YYYY/MM/DD HH:MM:SS (PID)> loaded repo into cache: $TESTTMP/cached (in  ...s)