Patchwork commands: add short option `-H` for `--hidden`

login
register
mail settings
Submitter Manuel Jacob
Date July 17, 2020, 6:50 p.m.
Message ID <91ac61b56b6ed95d9f62.1595011828@tmp>
Download mbox | patch
Permalink /patch/46796/
State New
Headers show

Comments

Manuel Jacob - July 17, 2020, 6:50 p.m.
# HG changeset patch
# User Manuel Jacob <me@manueljacob.de>
# Date 1595011777 -7200
#      Fri Jul 17 20:49:37 2020 +0200
# Node ID 91ac61b56b6ed95d9f62ba3615e8b160e6be8d9b
# Parent  a37f290a71240b851f5df900833f848efbab576a
# EXP-Topic hidden-shortcut
commands: add short option `-H` for `--hidden`

When digging in history, I have to use `--hidden` a lot. Therefore it would be a
major timesaver for me to have a short option for that.

I couldn’t think of another single letter that makes sense. Since `-h` is
already taken for `--help`, I decided for `-H`.
Manuel Jacob - July 17, 2020, 9:36 p.m.
I’m sorry for the non-optimal form and timing.

This was meant as an RFC patch. That’s why it contains no tests. It 
should have been flagged as such.

Now is probably not a good time for RFC patches. I was aware that RFC 
patches should not be sent after the freeze. That’s why I kinda rushed 
it before the freeze. As a discussion about a global option could easily 
extend until after the freeze, this is a violation of the spirit of that 
rule (getting everyone focused).

I’ll bring this up again after the release.


On 2020-07-17 20:50, Manuel Jacob wrote:
> # HG changeset patch
> # User Manuel Jacob <me@manueljacob.de>
> # Date 1595011777 -7200
> #      Fri Jul 17 20:49:37 2020 +0200
> # Node ID 91ac61b56b6ed95d9f62ba3615e8b160e6be8d9b
> # Parent  a37f290a71240b851f5df900833f848efbab576a
> # EXP-Topic hidden-shortcut
> commands: add short option `-H` for `--hidden`
> 
> When digging in history, I have to use `--hidden` a lot. Therefore it 
> would be a
> major timesaver for me to have a short option for that.
> 
> I couldn’t think of another single letter that makes sense. Since `-h` 
> is
> already taken for `--help`, I decided for `-H`.
> 
> diff --git a/mercurial/commands.py b/mercurial/commands.py
> --- a/mercurial/commands.py
> +++ b/mercurial/commands.py
> @@ -137,7 +137,7 @@
>      (b'', b'profile', None, _(b'print command execution profile')),
>      (b'', b'version', None, _(b'output version information and 
> exit')),
>      (b'h', b'help', None, _(b'display help and exit')),
> -    (b'', b'hidden', False, _(b'consider hidden changesets')),
> +    (b'H', b'hidden', False, _(b'consider hidden changesets')),
>      (
>          b'',
>          b'pager',
> _______________________________________________
> Mercurial-devel mailing list
> Mercurial-devel@mercurial-scm.org
> https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel

Patch

diff --git a/mercurial/commands.py b/mercurial/commands.py
--- a/mercurial/commands.py
+++ b/mercurial/commands.py
@@ -137,7 +137,7 @@ 
     (b'', b'profile', None, _(b'print command execution profile')),
     (b'', b'version', None, _(b'output version information and exit')),
     (b'h', b'help', None, _(b'display help and exit')),
-    (b'', b'hidden', False, _(b'consider hidden changesets')),
+    (b'H', b'hidden', False, _(b'consider hidden changesets')),
     (
         b'',
         b'pager',