Patchwork D8760: cext: remove unused variables

login
register
mail settings
Submitter phabricator
Date July 16, 2020, 5:49 p.m.
Message ID <differential-rev-PHID-DREV-a3ev6yh736fx7xm2wqyo-req@mercurial-scm.org>
Download mbox | patch
Permalink /patch/46766/
State Superseded
Headers show

Comments

phabricator - July 16, 2020, 5:49 p.m.
joerg.sonnenberger created this revision.
Herald added a reviewer: hg-reviewers.
Herald added a subscriber: mercurial-patches.

REPOSITORY
  rHG Mercurial

BRANCH
  default

REVISION DETAIL
  https://phab.mercurial-scm.org/D8760

AFFECTED FILES
  mercurial/cext/manifest.c
  mercurial/cext/revlog.c

CHANGE DETAILS




To: joerg.sonnenberger, #hg-reviewers
Cc: mercurial-patches, mercurial-devel

Patch

diff --git a/mercurial/cext/revlog.c b/mercurial/cext/revlog.c
--- a/mercurial/cext/revlog.c
+++ b/mercurial/cext/revlog.c
@@ -752,7 +752,6 @@ 
                              char phase)
 {
 	Py_ssize_t len = index_length(self);
-	PyObject *iter;
 	PyObject *item;
 	PyObject *iterator;
 	int rev, minrev = -1;
@@ -790,14 +789,12 @@ 
 	static const char trackedphases[] = {1, 2, 32, 96};
 	PyObject *ret = NULL;
 	PyObject *roots = Py_None;
-	PyObject *idx = NULL;
 	PyObject *pyphase = NULL;
 	PyObject *pyrev = NULL;
 	PyObject *phaseroots = NULL;
 	PyObject *phasessize = NULL;
 	PyObject *phasesets[4] = {NULL, NULL, NULL, NULL};
 	Py_ssize_t len = index_length(self);
-	const char *currentphase;
 	char *phases = NULL;
 	int minphaserev = -1, rev, i;
 	const int numphases = (int)(sizeof(phasesets) / sizeof(phasesets[0]));
@@ -880,7 +877,7 @@ 
 	phaseroots = _dict_new_presized(numphases);
 	if (phaseroots == NULL)
 		goto release;
-	for (int i = 0; i < numphases; ++i) {
+	for (i = 0; i < numphases; ++i) {
 		pyphase = PyInt_FromLong(trackedphases[i]);
 		if (pyphase == NULL)
 			goto release;
diff --git a/mercurial/cext/manifest.c b/mercurial/cext/manifest.c
--- a/mercurial/cext/manifest.c
+++ b/mercurial/cext/manifest.c
@@ -104,7 +104,6 @@ 
 	char flag;
 	PyObject *hash = nodeof(l, &flag);
 	ssize_t hlen;
-	Py_ssize_t hplen, flen;
 	PyObject *flags;
 	PyObject *tup;
 
@@ -296,7 +295,6 @@ 
 	Py_ssize_t pl;
 	line *l;
 	char flag;
-	Py_ssize_t consumed;
 	PyObject *ret = NULL, *path = NULL, *hash = NULL, *flags = NULL;
 	l = lmiter_nextline((lmIter *)o);
 	if (!l) {