Patchwork D8696: phases: updatephases should not skip internal phase

login
register
mail settings
Submitter phabricator
Date July 7, 2020, 10:38 p.m.
Message ID <differential-rev-PHID-DREV-4w4ibjelamq7wg3enham-req@mercurial-scm.org>
Download mbox | patch
Permalink /patch/46649/
State Superseded
Headers show

Comments

phabricator - July 7, 2020, 10:38 p.m.
joerg.sonnenberger created this revision.
Herald added a reviewer: hg-reviewers.
Herald added a subscriber: mercurial-patches.

REVISION SUMMARY
  Historically, updatephases used to skip the secret phase, but wasn't
  updated when archived and internal were added.

REPOSITORY
  rHG Mercurial

BRANCH
  default

REVISION DETAIL
  https://phab.mercurial-scm.org/D8696

AFFECTED FILES
  mercurial/phases.py

CHANGE DETAILS




To: joerg.sonnenberger, #hg-reviewers
Cc: mercurial-patches, mercurial-devel

Patch

diff --git a/mercurial/phases.py b/mercurial/phases.py
--- a/mercurial/phases.py
+++ b/mercurial/phases.py
@@ -777,12 +777,12 @@ 
 
 def updatephases(repo, trgetter, headsbyphase):
     """Updates the repo with the given phase heads"""
-    # Now advance phase boundaries of all but secret phase
+    # Now advance phase boundaries of all phases
     #
     # run the update (and fetch transaction) only if there are actually things
     # to update. This avoid creating empty transaction during no-op operation.
 
-    for phase in allphases[:-1]:
+    for phase in allphases:
         revset = b'%ln - _phase(%s)'
         heads = [c.node() for c in repo.set(revset, headsbyphase[phase], phase)]
         if heads: