Patchwork crecord: stop trying to import wcurses

login
register
mail settings
Submitter Manuel Jacob
Date June 27, 2020, 7:54 p.m.
Message ID <94987aadb22cee1d7da5.1593287696@tmp>
Download mbox | patch
Permalink /patch/46579/
State Accepted
Headers show

Comments

Manuel Jacob - June 27, 2020, 7:54 p.m.
# HG changeset patch
# User Manuel Jacob <me@manueljacob.de>
# Date 1593281981 -7200
#      Sat Jun 27 20:19:41 2020 +0200
# Node ID 94987aadb22cee1d7da52f365b3f532a94bbd4a6
# Parent  d2227d4c9e6b97b84b5c0c24b00f6ac3330be3fa
# EXP-Topic curses
crecord: stop trying to import wcurses

The original import of crecord in 2008 already said "I have no idea if wcurses
works with crecord...".

The last reference to a Python package called wcurses is
https://web.archive.org/web/20101025073658/http://adamv.com/dev/python/curses/.
However, the Python package from there is called "curses" and not "wcurses".

I didn’t find any evidence that it ever worked.
Yuya Nishihara - June 28, 2020, 5:56 a.m.
On Sat, 27 Jun 2020 21:54:56 +0200, Manuel Jacob wrote:
> # HG changeset patch
> # User Manuel Jacob <me@manueljacob.de>
> # Date 1593281981 -7200
> #      Sat Jun 27 20:19:41 2020 +0200
> # Node ID 94987aadb22cee1d7da52f365b3f532a94bbd4a6
> # Parent  d2227d4c9e6b97b84b5c0c24b00f6ac3330be3fa
> # EXP-Topic curses
> crecord: stop trying to import wcurses

Queued, thanks.

Patch

diff --git a/mercurial/crecord.py b/mercurial/crecord.py
--- a/mercurial/crecord.py
+++ b/mercurial/crecord.py
@@ -63,15 +63,7 @@ 
 
     curses.error
 except (ImportError, AttributeError):
-    # I have no idea if wcurses works with crecord...
-    try:
-        import wcurses as curses
-
-        curses.error
-    except (ImportError, AttributeError):
-        # wcurses is not shipped on Windows by default, or python is not
-        # compiled with curses
-        curses = False
+    curses = False
 
 
 class fallbackerror(error.Abort):