Patchwork D8628: tests: skip pyflakes for mercurial/thirdparty/

login
register
mail settings
Submitter phabricator
Date June 13, 2020, 9:07 a.m.
Message ID <differential-rev-PHID-DREV-nyqifbcr525ectclh3ru-req@mercurial-scm.org>
Download mbox | patch
Permalink /patch/46497/
State Superseded
Headers show

Comments

phabricator - June 13, 2020, 9:07 a.m.
marmoute created this revision.
Herald added a reviewer: hg-reviewers.
Herald added a subscriber: mercurial-patches.

REVISION SUMMARY
  The current version of pyflakes (2.2.0) correctly detects one issue:
  
    mercurial/thirdparty/selectors2.py:335:40 '...'.format(...) has unused arguments at position(s): 1
  
  But we're not interested in fixing lint errors in third-party code, so we need
  to exclude at least selectors2.py. And in the discussion for this patch it was
  decided to just skip the entire thirdparty directory.
  
  This is a graft of a similar fix that ended up on default.

REPOSITORY
  rHG Mercurial

BRANCH
  stable

REVISION DETAIL
  https://phab.mercurial-scm.org/D8628

AFFECTED FILES
  tests/test-check-pyflakes.t

CHANGE DETAILS




To: marmoute, #hg-reviewers
Cc: mercurial-patches, mercurial-devel

Patch

diff --git a/tests/test-check-pyflakes.t b/tests/test-check-pyflakes.t
--- a/tests/test-check-pyflakes.t
+++ b/tests/test-check-pyflakes.t
@@ -16,9 +16,7 @@ 
   $ testrepohg locate 'set:**.py or grep("^#!.*python")' \
   > -X hgext/fsmonitor/pywatchman \
   > -X mercurial/pycompat.py -X contrib/python-zstandard \
-  > -X mercurial/thirdparty/cbor \
-  > -X mercurial/thirdparty/concurrent \
-  > -X mercurial/thirdparty/zope \
+  > -X mercurial/thirdparty \
   > 2>/dev/null \
   > | xargs $PYTHON -m pyflakes 2>/dev/null | "$TESTDIR/filterpyflakes.py"
   contrib/perf.py:*: undefined name 'xrange' (glob) (?)