Patchwork D8618: tests: adjust to the new format in pyflakes output

login
register
mail settings
Submitter phabricator
Date June 6, 2020, 11:31 a.m.
Message ID <differential-rev-PHID-DREV-26yreg3wkinuynodahkh-req@mercurial-scm.org>
Download mbox | patch
Permalink /patch/46480/
State Superseded
Headers show

Comments

phabricator - June 6, 2020, 11:31 a.m.
av6 created this revision.
Herald added a reviewer: hg-reviewers.
Herald added a subscriber: mercurial-patches.

REVISION SUMMARY
  According to the pyflakes' NEWS.rst, the default output format changed
  recently:
  
    2.2.0 (2020-04-08)
    - Include column information in error messages
  
  So the lines now read:
  
    contrib/perf.py:149:15 undefined name 'xrange'
    mercurial/hgweb/server.py:427:13 undefined name 'reload'
    mercurial/util.py:2862:24 undefined name 'file'

REPOSITORY
  rHG Mercurial

BRANCH
  default

REVISION DETAIL
  https://phab.mercurial-scm.org/D8618

AFFECTED FILES
  tests/test-check-pyflakes.t

CHANGE DETAILS




To: av6, #hg-reviewers
Cc: mercurial-patches, mercurial-devel

Patch

diff --git a/tests/test-check-pyflakes.t b/tests/test-check-pyflakes.t
--- a/tests/test-check-pyflakes.t
+++ b/tests/test-check-pyflakes.t
@@ -9,7 +9,7 @@ 
   > print(undefinedname)
   > EOF
   $ $PYTHON -m pyflakes test.py 2>/dev/null | "$TESTDIR/filterpyflakes.py"
-  test.py:1: undefined name 'undefinedname'
+  test.py:1:* undefined name 'undefinedname' (glob)
   
   $ cd "`dirname "$TESTDIR"`"
 
@@ -21,8 +21,8 @@ 
   > -X mercurial/thirdparty/zope \
   > 2>/dev/null \
   > | xargs $PYTHON -m pyflakes 2>/dev/null | "$TESTDIR/filterpyflakes.py"
-  contrib/perf.py:*: undefined name 'xrange' (glob) (?)
-  mercurial/hgweb/server.py:*: undefined name 'reload' (glob) (?)
-  mercurial/util.py:*: undefined name 'file' (glob) (?)
-  mercurial/encoding.py:*: undefined name 'localstr' (glob) (?)
+  contrib/perf.py:*:* undefined name 'xrange' (glob) (?)
+  mercurial/hgweb/server.py:*:* undefined name 'reload' (glob) (?)
+  mercurial/util.py:*:* undefined name 'file' (glob) (?)
+  mercurial/encoding.py:*:* undefined name 'localstr' (glob) (?)