Patchwork D8600: scmutil: clarify getuipathfn comment

login
register
mail settings
Submitter phabricator
Date May 30, 2020, 2:05 p.m.
Message ID <differential-rev-PHID-DREV-mwb2krydoj7hdjnquwn6-req@mercurial-scm.org>
Download mbox | patch
Permalink /patch/46413/
State Superseded
Headers show

Comments

phabricator - May 30, 2020, 2:05 p.m.
valentin.gatienbaron created this revision.
Herald added a reviewer: hg-reviewers.
Herald added a subscriber: mercurial-patches.

REPOSITORY
  rHG Mercurial

BRANCH
  default

REVISION DETAIL
  https://phab.mercurial-scm.org/D8600

AFFECTED FILES
  mercurial/scmutil.py

CHANGE DETAILS




To: valentin.gatienbaron, #hg-reviewers
Cc: mercurial-patches, mercurial-devel

Patch

diff --git a/mercurial/scmutil.py b/mercurial/scmutil.py
--- a/mercurial/scmutil.py
+++ b/mercurial/scmutil.py
@@ -804,8 +804,8 @@ 
     if relative:
         cwd = repo.getcwd()
         if cwd != b'':
-            # this branch is correct when cwd == b'', ie cwd = repo root,
-            # but it's slower
+            # this branch would work even if cwd == b'' (ie cwd = repo
+            # root), but its generality makes the returned function slower
             pathto = repo.pathto
             return lambda f: pathto(f, cwd)
     if repo.ui.configbool(b'ui', b'slash'):