Patchwork D8507: rust-regex: prevent nonsensical `.*.*` pattern from happening

login
register
mail settings
Submitter phabricator
Date May 7, 2020, 10:16 p.m.
Message ID <differential-rev-PHID-DREV-jfpwvngx4zhs6gdiwmys-req@mercurial-scm.org>
Download mbox | patch
Permalink /patch/46289/
State Superseded
Headers show

Comments

phabricator - May 7, 2020, 10:16 p.m.
Alphare created this revision.
Herald added a reviewer: hg-reviewers.
Herald added a subscriber: mercurial-patches.

REPOSITORY
  rHG Mercurial

BRANCH
  stable

REVISION DETAIL
  https://phab.mercurial-scm.org/D8507

AFFECTED FILES
  rust/hg-core/src/filepatterns.rs

CHANGE DETAILS




To: Alphare, #hg-reviewers
Cc: mercurial-patches, mercurial-devel

Patch

diff --git a/rust/hg-core/src/filepatterns.rs b/rust/hg-core/src/filepatterns.rs
--- a/rust/hg-core/src/filepatterns.rs
+++ b/rust/hg-core/src/filepatterns.rs
@@ -189,7 +189,10 @@ 
             // The `regex` crate accepts `**` while `re2` and Python's `re`
             // do not. Checking for `*` correctly triggers the same error all
             // engines.
-            if pattern[0] == b'^' || pattern[0] == b'*' {
+            if pattern[0] == b'^'
+                || pattern[0] == b'*'
+                || pattern.starts_with(b".*")
+            {
                 return pattern.to_owned();
             }
             [&b".*"[..], pattern].concat()