Patchwork D8420: nodemap: move and update the commend about persistence being experimental

login
register
mail settings
Submitter phabricator
Date May 7, 2020, 3:35 p.m.
Message ID <7bff9d77b33c09035349e41bd4f3e1ed@localhost.localdomain>
Download mbox | patch
Permalink /patch/46275/
State Not Applicable
Headers show

Comments

phabricator - May 7, 2020, 3:35 p.m.
Closed by commit rHG3cfcbb219496: nodemap: move and update the commend about persistence being experimental (authored by marmoute).
This revision was automatically updated to reflect the committed changes.
This revision was not accepted when it landed; it landed in state "Needs Review".

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST UPDATE
  https://phab.mercurial-scm.org/D8420?vs=21068&id=21296

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D8420/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D8420

AFFECTED FILES
  mercurial/configitems.py

CHANGE DETAILS




To: marmoute, #hg-reviewers, Alphare
Cc: mercurial-patches, mercurial-devel

Patch

diff --git a/mercurial/configitems.py b/mercurial/configitems.py
--- a/mercurial/configitems.py
+++ b/mercurial/configitems.py
@@ -405,18 +405,6 @@ 
 coreconfigitem(
     b'devel', b'legacy.exchange', default=list,
 )
-# TODO before getting `persistent-nodemap` out of experimental
-#
-# * decide for a "status" of the persistent nodemap and associated location
-#   - part of the store next the revlog itself (new requirements)
-#   - part of the cache directory
-#   - part of an `index` directory
-#     (https://www.mercurial-scm.org/wiki/ComputedIndexPlan)
-# * do we want to use this for more than just changelog? if so we need:
-#   - simpler "pending" logic for them
-#   - double check the memory story (we dont want to keep all revlog in memory)
-#   - think about the naming scheme if we are in "cache"
-# * increment the version format to "1" and freeze it.
 coreconfigitem(
     b'devel', b'persistent-nodemap', default=False,
 )
@@ -783,6 +771,9 @@ 
 coreconfigitem(
     b'format', b'usestore', default=True,
 )
+# Right now, the only efficient implement of the nodemap logic is in Rust, so
+# the persistent nodemap feature needs to stay experimental as long as the Rust
+# extensions are an experimental feature.
 coreconfigitem(
     b'format', b'use-persistent-nodemap', default=False, experimental=True
 )