D8500: tests: use regular POSIX shell

Submitter	phabricator
Date	May 7, 2020, 1:03 p.m.
Message ID	<differential-rev-PHID-DREV-ckk6yrtv66kejkiiznme-req@mercurial-scm.org>
Download	mbox \| patch
Permalink	/patch/46266/
State	Superseded
Headers	show Return-Path: <mercurial-devel-bounces@mercurial-scm.org> Date: Thu, 7 May 2020 13:03:02 +0000 To: Phabricator <phabricator@mercurial-scm.org> From: "joerg.sonnenberger (Joerg Sonnenberger)" <phabricator@mercurial-scm.org> Subject: D8500: tests: use regular POSIX shell Message-ID: <differential-rev-PHID-DREV-ckk6yrtv66kejkiiznme-req@mercurial-scm.org> Precedence: bulk Thread-Topic: PHID-DREV-ckk6yrtv66kejkiiznme Thread-Index: Mjk2YTgzMjFkNmYxNmM0Yzc2YzNlNGQwNTc1 MIME-Version: 1.0 Cc: mercurial-devel@mercurial-scm.org Reply-To: "joerg.sonnenberger \(Joerg Sonnenberger\)" <phabricator+D8500+public+bbdbcb8dc8609970@mercurial-scm.org> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: mercurial-devel-bounces@mercurial-scm.org Sender: "Mercurial-devel" <mercurial-devel-bounces@mercurial-scm.org>

Comments

phabricator - May 7, 2020, 1:03 p.m.

joerg.sonnenberger created this revision.
Herald added a reviewer: hg-reviewers.
Herald added a subscriber: mercurial-patches.

REVISION SUMMARY
  wait-on-file requires one POSIX extension (sleep with non-integral
  argument), but it doesn't require any bash extensions, so just require a
  normal POSIX shell. While here, use consistent formatting without
  redundant ;

REPOSITORY
  rHG Mercurial

BRANCH
  stable

REVISION DETAIL
  https://phab.mercurial-scm.org/D8500

AFFECTED FILES
  tests/testlib/wait-on-file

CHANGE DETAILS




To: joerg.sonnenberger, #hg-reviewers
Cc: mercurial-patches, mercurial-devel

Patch

diff --git a/tests/testlib/wait-on-file b/tests/testlib/wait-on-file
--- a/tests/testlib/wait-on-file
+++ b/tests/testlib/wait-on-file
@@ -1,4 +1,4 @@ 
-#!/bin/bash
+#!/bin/sh
 #
 # wait up to TIMEOUT seconds until a WAIT_ON_FILE is created.
 #
@@ -22,13 +22,11 @@ 
     create="$3"
 fi
 
-if [ -n "$create" ];
-then
+if [ -n "$create" ]; then
     touch "$create"
     create=""
 fi
-while [ "$timer" -gt 0 ] && [ ! -f "$wait_on" ];
-do
+while [ "$timer" -gt 0 ] && [ ! -f "$wait_on" ]; do
     timer=$(( $timer - 1))
     sleep 0.01
 done

Patchwork D8500: tests: use regular POSIX shell

Comments

Patch