D8453: wait-on-file: adjust the timer counter

Submitter	phabricator
Date	April 16, 2020, 9 p.m.
Message ID	<differential-rev-PHID-DREV-kq63aseq4iplx3hss26c-req@mercurial-scm.org>
Download	mbox \| patch
Permalink	/patch/46177/
State	Superseded
Headers	show Return-Path: <mercurial-devel-bounces@mercurial-scm.org> Date: Thu, 16 Apr 2020 21:00:52 +0000 To: Phabricator <phabricator@mercurial-scm.org> From: "marmoute (Pierre-Yves David)" <phabricator@mercurial-scm.org> Subject: D8453: wait-on-file: adjust the timer counter Message-ID: <differential-rev-PHID-DREV-kq63aseq4iplx3hss26c-req@mercurial-scm.org> Precedence: bulk Thread-Topic: PHID-DREV-kq63aseq4iplx3hss26c Thread-Index: NDZmZWZkZDQwMzJhZTFiMjI3NWE4MjkxYjY3 MIME-Version: 1.0 Cc: mercurial-devel@mercurial-scm.org Reply-To: "marmoute \(Pierre-Yves David\)" <phabricator+D8453+public+6de87b5851e103e7@mercurial-scm.org> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: mercurial-devel-bounces@mercurial-scm.org Sender: "Mercurial-devel" <mercurial-devel-bounces@mercurial-scm.org>

Comments

phabricator - April 16, 2020, 9 p.m.

marmoute created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.

REVISION SUMMARY
  The wait performed in increment of 0.01 second, but the timer was expressed in
  second. So we did not wait 20s, we waited 0.2 second. Internally we adjust the
  counter to be expressed in centisecond. This prevent some flackyness in the
  test.

REPOSITORY
  rHG Mercurial

BRANCH
  default

REVISION DETAIL
  https://phab.mercurial-scm.org/D8453

AFFECTED FILES
  tests/testlib/wait-on-file

CHANGE DETAILS




To: marmoute, #hg-reviewers
Cc: mercurial-devel

Patch

diff --git a/tests/testlib/wait-on-file b/tests/testlib/wait-on-file
--- a/tests/testlib/wait-on-file
+++ b/tests/testlib/wait-on-file
@@ -13,7 +13,7 @@ 
 
 # if the test timeout have been extended, explicitly extend the provided timer
 if [ "$HGTEST_TIMEOUT_DEFAULT" -lt "$HGTEST_TIMEOUT" ]; then
-    timer=$(( ($timer * $HGTEST_TIMEOUT) / $HGTEST_TIMEOUT_DEFAULT ))
+    timer=$(( ( 100 * $timer * $HGTEST_TIMEOUT) / $HGTEST_TIMEOUT_DEFAULT ))
 fi
 
 wait_on="$2"

Patchwork D8453: wait-on-file: adjust the timer counter

Comments

Patch