Patchwork D8452: rust: update README with new information about the Re2 path

login
register
mail settings
Submitter phabricator
Date April 16, 2020, 4:42 p.m.
Message ID <8269823c5af20ea06546c2aaae8043af@localhost.localdomain>
Download mbox | patch
Permalink /patch/46160/
State Not Applicable
Headers show

Comments

phabricator - April 16, 2020, 4:42 p.m.
Closed by commit rHG8dbcd5138102: rust: update README with new information about the Re2 path (authored by Alphare).
This revision was automatically updated to reflect the committed changes.
This revision was not accepted when it landed; it landed in state "Needs Review".

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST UPDATE
  https://phab.mercurial-scm.org/D8452?vs=21129&id=21131

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D8452/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D8452

AFFECTED FILES
  rust/README.rst

CHANGE DETAILS




To: Alphare, #hg-reviewers
Cc: mercurial-devel

Patch

diff --git a/rust/README.rst b/rust/README.rst
--- a/rust/README.rst
+++ b/rust/README.rst
@@ -54,9 +54,17 @@ 
 a better option for getting the most speed out of your Mercurial. 
 
 If you want to use ``Re2``, you need to install ``Re2`` following Google's 
-guidelines: https://github.com/google/re2/wiki/Install
-Then, use ``HG_RUST_FEATURES=with-re2`` when building ``hg`` to use the full
-status code.
+guidelines: https://github.com/google/re2/wiki/Install.
+Then, use ``HG_RUST_FEATURES=with-re2`` and 
+``HG_RE2_PATH=system|<path to your re2 install>`` when building ``hg`` to 
+signal the use of Re2. Using the local path instead of the "system" RE2 links
+it statically.
+
+For example::
+
+  $ HG_RUST_FEATURES=with-re2 HG_RE2_PATH=system make PURE=--rust
+  $ # OR
+  $ HG_RUST_FEATURES=with-re2 HG_RE2_PATH=/path/to/re2 make PURE=--rust
 
 Developing Rust
 ===============