Patchwork D8439: make: drop the `-c` arg to `install` in the documentation makefile

login
register
mail settings
Submitter phabricator
Date April 16, 2020, 2:28 a.m.
Message ID <differential-rev-PHID-DREV-j5b5pntq67dfpel72uud-req@mercurial-scm.org>
Download mbox | patch
Permalink /patch/46144/
State Superseded
Headers show

Comments

phabricator - April 16, 2020, 2:28 a.m.
mharbison72 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.

REVISION SUMMARY
  This arg caused `gmake install` on OpenIndiana 2019.10 (illumos) fail with:
  
    install: The -c, -f, -n options each require a directory following!
    install: The -c, -f, -n options each require a directory following!
    install: The -c, -f, -n options each require a directory following!
    gmake[1]: *** [Makefile:41: install] Error 2
    gmake[1]: Leaving directory '/usr/local/share/mercurial/doc'
  
  The workaround is to run `gmake install-bin`.
  
  The man page for 10.14 says this is to copy the file and is only for
  compatability, as it is the default.  The CentOS 7 man page says it is ignored.
  The top level makefile doesn't use this argument at all, so I'm not sure why
  it's here.

REPOSITORY
  rHG Mercurial

BRANCH
  stable

REVISION DETAIL
  https://phab.mercurial-scm.org/D8439

AFFECTED FILES
  doc/Makefile

CHANGE DETAILS




To: mharbison72, #hg-reviewers
Cc: mercurial-devel
phabricator - April 16, 2020, 2:37 a.m.
mharbison72 added a comment.


  This helps it get further, but then it dies with messages like:
  
    find: cycle detected for /lib/secure/32/
    find: cycle detected for /lib/crypto/32/
    find: cycle detected for /lib/32/
    ...
    install: hg-ssh.8 was not found anywhere!
    find: cycle detected for /lib/secure/32/
    find: cycle detected for /lib/crypto/32/
    find: cycle detected for /lib/32/
    ...
    install: hgrc.5 was not found anywhere!
    ...

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D8439/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D8439

To: mharbison72, #hg-reviewers
Cc: mercurial-devel
phabricator - April 16, 2020, 2:50 a.m.
mharbison72 added a comment.


  In D8439#125864 <https://phab.mercurial-scm.org/D8439#125864>, @mharbison72 wrote:
  
  > This helps it get further, but then it dies with messages like:
  >
  >   find: cycle detected for /lib/secure/32/
  >   find: cycle detected for /lib/crypto/32/
  >   find: cycle detected for /lib/32/
  >   ...
  >   install: hg-ssh.8 was not found anywhere!
  >   find: cycle detected for /lib/secure/32/
  >   find: cycle detected for /lib/crypto/32/
  >   find: cycle detected for /lib/32/
  >   ...
  >   install: hgrc.5 was not found anywhere!
  >   ...
  
  ... and `gmake INSTALL=ginstall install` works around that.  But I think this patch is still valid.

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D8439/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D8439

To: mharbison72, #hg-reviewers
Cc: mercurial-devel

Patch

diff --git a/doc/Makefile b/doc/Makefile
--- a/doc/Makefile
+++ b/doc/Makefile
@@ -5,7 +5,7 @@ 
 	../mercurial/helptext/*.txt ../hgext/*.py ../hgext/*/__init__.py
 PREFIX=/usr/local
 MANDIR=$(PREFIX)/share/man
-INSTALL=install -c -m 644
+INSTALL=install -m 644
 PYTHON?=python
 RSTARGS=