Patchwork D8424: manifest: fix missing `el` on an `elif` spotted by yuya

login
register
mail settings
Submitter phabricator
Date April 15, 2020, 2:56 p.m.
Message ID <differential-rev-PHID-DREV-n57ut3ysmk4n6ab2th2w-req@mercurial-scm.org>
Download mbox | patch
Permalink /patch/46127/
State Superseded
Headers show

Comments

phabricator - April 15, 2020, 2:56 p.m.
durin42 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.

REVISION SUMMARY
  This can be amended into 2db2e9e5 <https://phab.mercurial-scm.org/rHG2db2e9e585b350cc4f604d1010c5068840fff739>.

REPOSITORY
  rHG Mercurial

BRANCH
  default

REVISION DETAIL
  https://phab.mercurial-scm.org/D8424

AFFECTED FILES
  mercurial/manifest.py

CHANGE DETAILS




To: durin42, #hg-reviewers
Cc: mercurial-devel
phabricator - April 15, 2020, 3:09 p.m.
Alphare added a comment.
Alphare accepted this revision.
Alphare added subscribers: yuja, Alphare.


  Ouch, missed that. Thanks @yuja.

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D8424/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D8424

To: durin42, #hg-reviewers, Alphare
Cc: Alphare, yuja, mercurial-devel
phabricator - April 16, 2020, 4:40 p.m.
pulkit added a comment.


  Looks like this was amended and not needed anymore.

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D8424/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D8424

To: durin42, #hg-reviewers, Alphare
Cc: pulkit, Alphare, yuja, mercurial-devel
phabricator - April 16, 2020, 4:50 p.m.
durin42 added a comment.
durin42 abandoned this revision.


  Yep it got folded.

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D8424/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D8424

To: durin42, #hg-reviewers, Alphare
Cc: pulkit, Alphare, yuja, mercurial-devel

Patch

diff --git a/mercurial/manifest.py b/mercurial/manifest.py
--- a/mercurial/manifest.py
+++ b/mercurial/manifest.py
@@ -61,7 +61,7 @@ 
         if 64 < nl:
             # modern hash, full width
             yield f, bin(n[:64]), n[64:]
-        if 40 < nl < 45:
+        elif 40 < nl < 45:
             # legacy hash, always sha1
             yield f, bin(n[:40]), n[40:]
         else: