Patchwork D8375: manifest: leave a TODO where we may have more work for sha1 portability

login
register
mail settings
Submitter phabricator
Date April 14, 2020, 7:19 p.m.
Message ID <abc7938c578fff0017bc19209503ed0a@localhost.localdomain>
Download mbox | patch
Permalink /patch/46116/
State Not Applicable
Headers show

Comments

phabricator - April 14, 2020, 7:19 p.m.
Closed by commit rHGf0d88d20654b: manifest: leave a TODO where we may have more work for sha1 portability (authored by durin42).
This revision was automatically updated to reflect the committed changes.

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST UPDATE
  https://phab.mercurial-scm.org/D8375?vs=21055&id=21087

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D8375/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D8375

AFFECTED FILES
  mercurial/manifest.py

CHANGE DETAILS




To: durin42, #hg-reviewers, Alphare, pulkit
Cc: mercurial-devel

Patch

diff --git a/mercurial/manifest.py b/mercurial/manifest.py
--- a/mercurial/manifest.py
+++ b/mercurial/manifest.py
@@ -1432,6 +1432,7 @@ 
                 set = super(manifestfulltextcache, self).__setitem__
                 # ignore trailing data, this is a cache, corruption is skipped
                 while True:
+                    # TODO do we need to do work here for sha1 portability?
                     node = fp.read(20)
                     if len(node) < 20:
                         break