Patchwork D8416: nodemap: move on disk file to version 1

login
register
mail settings
Submitter phabricator
Date April 14, 2020, 3:49 p.m.
Message ID <differential-rev-PHID-DREV-bugfraluedbn5nkxn27q-req@mercurial-scm.org>
Download mbox | patch
Permalink /patch/46089/
State Superseded
Headers show

Comments

phabricator - April 14, 2020, 3:49 p.m.
marmoute created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.

REVISION SUMMARY
  The current format contains the information we need, lets freeze it before the
  release.

REPOSITORY
  rHG Mercurial

BRANCH
  default

REVISION DETAIL
  https://phab.mercurial-scm.org/D8416

AFFECTED FILES
  mercurial/revlogutils/nodemap.py

CHANGE DETAILS




To: marmoute, #hg-reviewers
Cc: mercurial-devel
phabricator - April 16, 2020, 4:07 p.m.
durin42 added inline comments.

INLINE COMMENTS

> nodemap.py:270
>  
>  # version 0 is experimental, no BC garantee, do no use outside of tests.
> +ONDISK_VERSION = 1

I feel like this comment is outdated? please send a follow-up (even if it's for stable after the freeze) on this.

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D8416/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D8416

To: marmoute, #hg-reviewers
Cc: durin42, mercurial-devel
phabricator - April 16, 2020, 5:15 p.m.
marmoute added a comment.


  good catch, I updated the diff.

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D8416/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D8416

To: marmoute, #hg-reviewers
Cc: durin42, mercurial-devel

Patch

diff --git a/mercurial/revlogutils/nodemap.py b/mercurial/revlogutils/nodemap.py
--- a/mercurial/revlogutils/nodemap.py
+++ b/mercurial/revlogutils/nodemap.py
@@ -268,7 +268,7 @@ 
 # nodemap gains the necessary features to be used in production.
 
 # version 0 is experimental, no BC garantee, do no use outside of tests.
-ONDISK_VERSION = 0
+ONDISK_VERSION = 1
 S_VERSION = struct.Struct(">B")
 S_HEADER = struct.Struct(">BQQQQ")