Patchwork D8413: nodemap: access the mmap opener option using bytes

login
register
mail settings
Submitter phabricator
Date April 14, 2020, 3:48 p.m.
Message ID <differential-rev-PHID-DREV-dhjxdei3gwa56zx2h5c5-req@mercurial-scm.org>
Download mbox | patch
Permalink /patch/46088/
State Superseded
Headers show

Comments

phabricator - April 14, 2020, 3:48 p.m.
marmoute created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.

REVISION SUMMARY
  The key is bytes and need to be accessed s such.

REPOSITORY
  rHG Mercurial

BRANCH
  default

REVISION DETAIL
  https://phab.mercurial-scm.org/D8413

AFFECTED FILES
  mercurial/revlogutils/nodemap.py

CHANGE DETAILS




To: marmoute, #hg-reviewers
Cc: mercurial-devel

Patch

diff --git a/mercurial/revlogutils/nodemap.py b/mercurial/revlogutils/nodemap.py
--- a/mercurial/revlogutils/nodemap.py
+++ b/mercurial/revlogutils/nodemap.py
@@ -48,7 +48,7 @@ 
     docket.data_unused = data_unused
 
     filename = _rawdata_filepath(revlog, docket)
-    use_mmap = revlog.opener.options.get("exp-persistent-nodemap.mmap")
+    use_mmap = revlog.opener.options.get(b"exp-persistent-nodemap.mmap")
     try:
         with revlog.opener(filename) as fd:
             if use_mmap:
@@ -137,7 +137,7 @@ 
     can_incremental = util.safehasattr(revlog.index, "nodemap_data_incremental")
     ondisk_docket = revlog._nodemap_docket
     feed_data = util.safehasattr(revlog.index, "update_nodemap_data")
-    use_mmap = revlog.opener.options.get("exp-persistent-nodemap.mmap")
+    use_mmap = revlog.opener.options.get(b"exp-persistent-nodemap.mmap")
 
     data = None
     # first attemp an incremental update of the data