From patchwork Fri Apr 10 17:02:18 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: D8393: revset: rename generationsrel() to generationssubrel() From: phabricator X-Patchwork-Id: 46058 Message-Id: To: Phabricator Cc: mercurial-devel@mercurial-scm.org Date: Fri, 10 Apr 2020 17:02:18 +0000 av6 created this revision. av6 added a reviewer: yuja. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This highlights that this is an implementation of 'x#y[z]' relation subscript operator as opposed to 'x#y' relation operator. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D8393 AFFECTED FILES mercurial/revset.py CHANGE DETAILS To: av6, yuja, #hg-reviewers Cc: mercurial-devel diff --git a/mercurial/revset.py b/mercurial/revset.py --- a/mercurial/revset.py +++ b/mercurial/revset.py @@ -281,7 +281,7 @@ return ancdepths, descdepths -def generationsrel(repo, subset, x, rel, z, order): +def generationssubrel(repo, subset, x, rel, z, order): # TODO: rewrite tests, and drop startdepth argument from ancestors() and # descendants() predicates a, b = getintrange( @@ -2634,8 +2634,8 @@ } subscriptrelations = { - b"g": generationsrel, - b"generations": generationsrel, + b"g": generationssubrel, + b"generations": generationssubrel, }