Patchwork D8391: histedit: add test that an invalid editor doesn't bork client state

login
register
mail settings
Submitter phabricator
Date April 9, 2020, 7:47 p.m.
Message ID <differential-rev-PHID-DREV-j2fhyvwzi5x63a7oxila-req@mercurial-scm.org>
Download mbox | patch
Permalink /patch/46054/
State Superseded
Headers show

Comments

phabricator - April 9, 2020, 7:47 p.m.
durin42 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.

REVISION SUMMARY
  We had a report of a situation like this borking a user at Google, but
  I can't reproduce it in a test. Let's at least backstop the issue with
  a test, so we don't accidentally introduce such a bug...

REPOSITORY
  rHG Mercurial

BRANCH
  default

REVISION DETAIL
  https://phab.mercurial-scm.org/D8391

AFFECTED FILES
  tests/test-histedit-non-commute.t

CHANGE DETAILS




To: durin42, #hg-reviewers
Cc: mercurial-devel

Patch

diff --git a/tests/test-histedit-non-commute.t b/tests/test-histedit-non-commute.t
--- a/tests/test-histedit-non-commute.t
+++ b/tests/test-histedit-non-commute.t
@@ -300,4 +300,7 @@ 
      summary:     Initial commit
   
 
+An invalid editor shouldn't leave the user in a broken state:
+  $ EDITOR=totally-not-a-thing-unsensible-editor-value hg histedit 4
+
   $ cd ..