D8354: histedit: add missing b prefix to a string

Submitter	phabricator
Date	April 1, 2020, 9:26 p.m.
Message ID	<differential-rev-PHID-DREV-r3jaiuffoezx62yolri6-req@mercurial-scm.org>
Download	mbox \| patch
Permalink	/patch/45985/
State	Superseded
Headers	show Return-Path: <mercurial-devel-bounces@mercurial-scm.org> Date: Wed, 1 Apr 2020 21:26:48 +0000 To: Phabricator <phabricator@mercurial-scm.org> From: "spectral (Kyle Lippincott)" <phabricator@mercurial-scm.org> Subject: D8354: histedit: add missing b prefix to a string Message-ID: <differential-rev-PHID-DREV-r3jaiuffoezx62yolri6-req@mercurial-scm.org> Precedence: bulk Thread-Topic: PHID-DREV-r3jaiuffoezx62yolri6 Thread-Index: MDRhNDg4NDdjZjViNTMxOTZjYmI3MmZmMWFm MIME-Version: 1.0 Cc: mercurial-devel@mercurial-scm.org Reply-To: "spectral \(Kyle Lippincott\)" <phabricator+D8354+public+1e911d78194bfded@mercurial-scm.org> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: mercurial-devel-bounces@mercurial-scm.org Sender: "Mercurial-devel" <mercurial-devel-bounces@mercurial-scm.org>

Comments

phabricator - April 1, 2020, 9:26 p.m.

spectral created this revision.
Herald added a reviewer: durin42.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.

REVISION SUMMARY
  If i18n is disabled (such as via HGPLAIN=1), `_()` doesn't convert from str to
  bytes, so this raises a TypeError on py3.

REPOSITORY
  rHG Mercurial

BRANCH
  default

REVISION DETAIL
  https://phab.mercurial-scm.org/D8354

AFFECTED FILES
  hgext/histedit.py

CHANGE DETAILS




To: spectral, durin42, #hg-reviewers
Cc: mercurial-devel

Patch

diff --git a/hgext/histedit.py b/hgext/histedit.py
--- a/hgext/histedit.py
+++ b/hgext/histedit.py
@@ -291,7 +291,7 @@ 
     Commands are only included once.
     """
     intro = _(
-        """Edit history between %s and %s
+        b"""Edit history between %s and %s
 
 Commits are listed from least to most recent

Patchwork D8354: histedit: add missing b prefix to a string

Comments

Patch