Submitter | phabricator |
---|---|
Date | March 29, 2020, 1:40 a.m. |
Message ID | <differential-rev-PHID-DREV-c5ussf5xtzzc666nmof5-req@mercurial-scm.org> |
Download | mbox | patch |
Permalink | /patch/45925/ |
State | Superseded |
Headers | show |
Comments
mharbison72 added a comment.
mharbison72 accepted this revision.
> I suspect the Windows process code in Python doesn't accept bytes and the POSIX code does?
That's definitely my experience, and the reason for `procutil.tonativestr()`.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST ACTION
https://phab.mercurial-scm.org/D8334/new/
REVISION DETAIL
https://phab.mercurial-scm.org/D8334
To: indygreg, #hg-reviewers, mharbison72
Cc: mharbison72, mercurial-devel
Patch
diff --git a/tests/hghave.py b/tests/hghave.py --- a/tests/hghave.py +++ b/tests/hghave.py @@ -335,7 +335,7 @@ @check("rust", "Using the Rust extensions") def has_rust(): """Check is the mercurial currently running is using some rust code""" - cmd = b'hg debuginstall --quiet 2>&1' + cmd = 'hg debuginstall --quiet 2>&1' match = br'checking module policy \(([^)]+)\)' policy = matchoutput(cmd, match) if not policy: