Patchwork D8327: setup: relax -Werror for declaration-after-statement on Python 3.9

login
register
mail settings
Submitter phabricator
Date March 26, 2020, 10:50 a.m.
Message ID <8862b718a652ae610015831cf37b9690@localhost.localdomain>
Download mbox | patch
Permalink /patch/45907/
State Not Applicable
Headers show

Comments

phabricator - March 26, 2020, 10:50 a.m.
Closed by commit rHG960770add699: setup: relax -Werror for declaration-after-statement on Python 3.9 (authored by durin42).
This revision was automatically updated to reflect the committed changes.

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST UPDATE
  https://phab.mercurial-scm.org/D8327?vs=20874&id=20890

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D8327/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D8327

AFFECTED FILES
  setup.py

CHANGE DETAILS




To: durin42, #hg-reviewers, Alphare, pulkit
Cc: mercurial-devel

Patch

diff --git a/setup.py b/setup.py
--- a/setup.py
+++ b/setup.py
@@ -1270,8 +1270,9 @@ 
 
 common_cflags = []
 
-# MSVC 2008 still needs declarations at the top of the scope.
-if os.name != 'nt':
+# MSVC 2008 still needs declarations at the top of the scope, but Python 3.9
+# makes declarations not at the top of a scope in the headers.
+if os.name != 'nt' and sys.version_info[1] < 9:
     common_cflags = ['-Werror=declaration-after-statement']
 
 osutil_cflags = []