Patchwork D8331: py3: make setup.py's hgcommand() consistently return bytes

login
register
mail settings
Submitter phabricator
Date March 26, 2020, 10:18 a.m.
Message ID <0eb19e3e3f78d2a83202b3606ae1e11e@localhost.localdomain>
Download mbox | patch
Permalink /patch/45906/
State Not Applicable
Headers show

Comments

phabricator - March 26, 2020, 10:18 a.m.
Closed by commit rHGbda050bc9987: py3: make setup.py&#039;s hgcommand() consistently return bytes (authored by martinvonz).
This revision was automatically updated to reflect the committed changes.

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST UPDATE
  https://phab.mercurial-scm.org/D8331?vs=20886&id=20888

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D8331/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D8331

AFFECTED FILES
  setup.py

CHANGE DETAILS




To: martinvonz, #hg-reviewers, mharbison72, pulkit
Cc: mercurial-devel

Patch

diff --git a/setup.py b/setup.py
--- a/setup.py
+++ b/setup.py
@@ -274,7 +274,7 @@ 
         if err or returncode != 0:
             printf("stderr from '%s':" % (' '.join(cmd)), file=sys.stderr)
             printf(err, file=sys.stderr)
-            return ''
+            return b''
         return out