Submitter | phabricator |
---|---|
Date | March 25, 2020, 4:53 p.m. |
Message ID | <61b179eff8feb2e1eff6038a5ca1b4ba@localhost.localdomain> |
Download | mbox | patch |
Permalink | /patch/45885/ |
State | Not Applicable |
Headers | show |
Comments
Patch
diff --git a/mercurial/ui.py b/mercurial/ui.py --- a/mercurial/ui.py +++ b/mercurial/ui.py @@ -1914,6 +1914,12 @@ # instead default to E to plumb commit messages to # avoid confusion. editor = b'E' + elif pycompat.isdarwin: + # vi on darwin is POSIX compatible to a fault, and that includes + # exiting non-zero if you make any mistake when running an ex + # command. Proof: `vi -c ':unknown' -c ':qa'; echo $?` produces 1, + # while s/vi/vim/ doesn't. + editor = b'vim' else: editor = b'vi' return encoding.environ.get(b"HGEDITOR") or self.config(