Patchwork D8301: phabricator: remove duplicated byteskwargs conversion

login
register
mail settings
Submitter phabricator
Date March 18, 2020, 7:12 p.m.
Message ID <differential-rev-PHID-DREV-75gevut25ygplggamwko-req@mercurial-scm.org>
Download mbox | patch
Permalink /patch/45821/
State Superseded
Headers show

Comments

phabricator - March 18, 2020, 7:12 p.m.
durin42 created this revision.
Herald added subscribers: mercurial-devel, Kwan.
Herald added a reviewer: hg-reviewers.

REVISION SUMMARY
  Fixes things on Python 3.

REPOSITORY
  rHG Mercurial

BRANCH
  default

REVISION DETAIL
  https://phab.mercurial-scm.org/D8301

AFFECTED FILES
  hgext/phabricator.py

CHANGE DETAILS




To: durin42, #hg-reviewers
Cc: Kwan, mercurial-devel
phabricator - March 18, 2020, 8:26 p.m.
mharbison72 added a comment.
mharbison72 accepted this revision.


  Thanks, I just hit this myself.
  
  It also looks like the `create alpha for phabricator test €` test is broken.  Can we get the `pytest-vcr` package installed on the builders?

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D8301/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D8301

To: durin42, #hg-reviewers, mharbison72
Cc: mharbison72, Kwan, mercurial-devel

Patch

diff --git a/hgext/phabricator.py b/hgext/phabricator.py
--- a/hgext/phabricator.py
+++ b/hgext/phabricator.py
@@ -1764,7 +1764,6 @@ 
                     ui.note(msg + b'\n')
                     parents = [repo[node]]
 
-    opts = pycompat.byteskwargs(opts)
     if opts.get(b'stack'):
         spec = b':(%s)' % spec
     drevs = querydrev(repo.ui, spec)