Patchwork D8181: nodemap: add a todo list for getting out of experimental

login
register
mail settings
Submitter phabricator
Date March 11, 2020, 3:43 p.m.
Message ID <c89301461883a12c06296740bcc4e300@localhost.localdomain>
Download mbox | patch
Permalink /patch/45705/
State Not Applicable
Headers show

Comments

phabricator - March 11, 2020, 3:43 p.m.
Closed by commit rHG15a033cabc19: nodemap: add a todo list for getting out of experimental (authored by marmoute).
This revision was automatically updated to reflect the committed changes.
This revision was not accepted when it landed; it landed in state "Needs Review".

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST UPDATE
  https://phab.mercurial-scm.org/D8181?vs=20580&id=20702

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D8181/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D8181

AFFECTED FILES
  mercurial/configitems.py

CHANGE DETAILS




To: marmoute, #hg-reviewers
Cc: mercurial-devel

Patch

diff --git a/mercurial/configitems.py b/mercurial/configitems.py
--- a/mercurial/configitems.py
+++ b/mercurial/configitems.py
@@ -405,6 +405,23 @@ 
 coreconfigitem(
     b'devel', b'legacy.exchange', default=list,
 )
+# TODO before getting `persistent-nodemap` out of experimental
+#
+# * code/tests around aborted transaction
+# * code/tests around pending data for hooks
+# * code/tests around detection of invalid cache
+#   (eg: after strip from an incompatible client)
+# * regenerate a new nodemap when the unused/total ration is to high
+# * decide for a "status" of the persistent nodemap and associated location
+#   - part of the store next the revlog itself (new requirements)
+#   - part of the cache directory
+#   - part of an `index` directory
+#     (https://www.mercurial-scm.org/wiki/ComputedIndexPlan)
+# * do we want to use this for more than just changelog? if so we need:
+#   - simpler "pending" logic for them
+#   - double check the memory story (we dont want to keep all revlog in memory)
+#   - think about the naming scheme if we are in "cache"
+# * increment the version format to "1" and freeze it.
 coreconfigitem(
     b'devel', b'persistent-nodemap', default=False,
 )