Patchwork [stable] tests: fix isinstance test of wrong variable

login
register
mail settings
Submitter Manuel Jacob
Date March 9, 2020, 12:13 a.m.
Message ID <1320093a99dc1a1ed796.1583712800@tmp>
Download mbox | patch
Permalink /patch/45623/
State Accepted
Headers show

Comments

Manuel Jacob - March 9, 2020, 12:13 a.m.
# HG changeset patch
# User Manuel Jacob <me@manueljacob.de>
# Date 1583712719 -3600
#      Mon Mar 09 01:11:59 2020 +0100
# Node ID 1320093a99dc1a1ed796b230dd2f1b87ea045eac
# Parent  ae4272a4f77c327ff08d48d50460d573fe003757
# EXP-Topic remove-implicit-str-conversions
tests: fix isinstance test of wrong variable

3086a8627b2970cd7fbf49bc69413c08c68d5514 changed self._case to be a list, but
it was forgotten to adjust this line.
Yuya Nishihara - March 9, 2020, 1:55 p.m.
On Mon, 09 Mar 2020 01:13:20 +0100, Manuel Jacob wrote:
> # HG changeset patch
> # User Manuel Jacob <me@manueljacob.de>
> # Date 1583712719 -3600
> #      Mon Mar 09 01:11:59 2020 +0100
> # Node ID 1320093a99dc1a1ed796b230dd2f1b87ea045eac
> # Parent  ae4272a4f77c327ff08d48d50460d573fe003757
> # EXP-Topic remove-implicit-str-conversions
> tests: fix isinstance test of wrong variable

Queued for stable, thanks.

Patch

diff --git a/tests/run-tests.py b/tests/run-tests.py
--- a/tests/run-tests.py
+++ b/tests/run-tests.py
@@ -1759,7 +1759,7 @@ 
 
         if self._case:
             casestr = b'#'.join(self._case)
-            if isinstance(self._case, str):
+            if isinstance(casestr, str):
                 quoted = shellquote(casestr)
             else:
                 quoted = shellquote(casestr.decode('utf8')).encode('utf8')