D8262: git: add readfast() method to manifest

Submitter	phabricator
Date	March 7, 2020, 9:51 p.m.
Message ID	<differential-rev-PHID-DREV-r25w2mr4iflybzxjufwh-req@mercurial-scm.org>
Download	mbox \| patch
Permalink	/patch/45612/
State	Superseded
Headers	show Return-Path: <mercurial-devel-bounces@mercurial-scm.org> Date: Sat, 7 Mar 2020 21:51:45 +0000 To: Phabricator <phabricator@mercurial-scm.org> From: "durin42 (Augie Fackler)" <phabricator@mercurial-scm.org> Subject: D8262: git: add readfast() method to manifest Message-ID: <differential-rev-PHID-DREV-r25w2mr4iflybzxjufwh-req@mercurial-scm.org> Precedence: bulk Thread-Topic: PHID-DREV-r25w2mr4iflybzxjufwh Thread-Index: MjIzNTM0MWY4Y2E2YTgyNGM0NjJkOTk0ZjAy MIME-Version: 1.0 Cc: mercurial-devel@mercurial-scm.org Reply-To: "durin42 \(Augie Fackler\)" <phabricator+D8262+public+182a5ebb48458f13@mercurial-scm.org> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: mercurial-devel-bounces@mercurial-scm.org Sender: "Mercurial-devel" <mercurial-devel-bounces@mercurial-scm.org>

Comments

phabricator - March 7, 2020, 9:51 p.m.

durin42 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.

REVISION SUMMARY
  Mysteriously, on a different system a handful of things don't work
  without this, including log. This is especially odd to be because log
  works in the test. In any event, it's legal for readfast() to just
  return read(), so that's what we do.

REPOSITORY
  rHG Mercurial

BRANCH
  default

REVISION DETAIL
  https://phab.mercurial-scm.org/D8262

AFFECTED FILES
  hgext/git/manifest.py

CHANGE DETAILS




To: durin42, #hg-reviewers
Cc: mercurial-devel

phabricator - March 7, 2020, 10:03 p.m.

martinvonz added a comment.


  FYI, I saw this failure on `hg log -r` with an partial nodeid.

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D8262/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D8262

To: durin42, #hg-reviewers
Cc: martinvonz, mercurial-devel

phabricator - March 9, 2020, 8:59 a.m.

This revision is now accepted and ready to land.
pulkit added a comment.
pulkit accepted this revision.


  Looks like we should test the interfaces.

REPOSITORY
  rHG Mercurial

BRANCH
  default

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D8262/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D8262

To: durin42, #hg-reviewers, pulkit
Cc: pulkit, martinvonz, mercurial-devel

Patch

diff --git a/hgext/git/manifest.py b/hgext/git/manifest.py
--- a/hgext/git/manifest.py
+++ b/hgext/git/manifest.py
@@ -195,6 +195,9 @@ 
     def read(self):
         return gittreemanifest(self._repo, self._tree, None)
 
+    def readfast(self, shallow=False):
+        return self.read()
+
     def copy(self):
         # NB: it's important that we return a memgittreemanifestctx
         # because the caller expects a mutable manifest.

Patchwork D8262: git: add readfast() method to manifest

Comments

Patch