Patchwork D8137: phabricator: add a config knob to import in the secret phase

login
register
mail settings
Submitter phabricator
Date March 6, 2020, 4:04 p.m.
Message ID <32f1ca5d8d05de97ed9da24f02a2641b@localhost.localdomain>
Download mbox | patch
Permalink /patch/45554/
State Not Applicable
Headers show

Comments

phabricator - March 6, 2020, 4:04 p.m.
mharbison72 updated this revision to Diff 20555.

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST UPDATE
  https://phab.mercurial-scm.org/D8137?vs=20513&id=20555

BRANCH
  default

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D8137/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D8137

AFFECTED FILES
  hgext/phabricator.py
  tests/test-phabricator.t

CHANGE DETAILS




To: mharbison72, #hg-reviewers, durin42
Cc: durin42, Kwan, mercurial-devel

Patch

diff --git a/tests/test-phabricator.t b/tests/test-phabricator.t
--- a/tests/test-phabricator.t
+++ b/tests/test-phabricator.t
@@ -345,5 +345,39 @@ 
   o  0   c44b38f24a45   1970-01-01 00:00 +0000   test
        create alpha for phabricator test \x80 (esc)
   
+Phabimport can create secret commits
+
+  $ hg rollback --config ui.rollback=True
+  repository tip rolled back to revision 1 (undo phabimport)
+  $ hg phabimport --stack 'D7918' --test-vcr "$VCR/phabimport-stack.json" \
+  >    --config phabimport.secret=True
+  applying patch from D7917
+  applying patch from D7918
+  $ hg log -T phases
+  changeset:   3:aaef04066140
+  tag:         tip
+  phase:       secret
+  user:        test
+  date:        Thu Jan 01 00:00:00 1970 +0000
+  summary:     create draft change for phabricator testing
+  
+  changeset:   2:8de3712202d1
+  phase:       secret
+  user:        test
+  date:        Thu Jan 01 00:00:00 1970 +0000
+  summary:     create public change for phabricator testing
+  
+  changeset:   1:a692622e6937
+  phase:       public
+  user:        test
+  date:        Thu Jan 01 00:00:00 1970 +0000
+  summary:     create beta for phabricator test
+  
+  changeset:   0:c44b38f24a45
+  phase:       public
+  user:        test
+  date:        Thu Jan 01 00:00:00 1970 +0000
+  summary:     create alpha for phabricator test \x80 (esc)
+  
 
   $ cd ..
diff --git a/hgext/phabricator.py b/hgext/phabricator.py
--- a/hgext/phabricator.py
+++ b/hgext/phabricator.py
@@ -124,6 +124,9 @@ 
 eh.configitem(
     b'phabsend', b'confirm', default=False,
 )
+eh.configitem(
+    b'phabimport', b'secret', default=False,
+)
 
 colortable = {
     b'phabricator.action.created': b'green',
@@ -1729,6 +1732,9 @@ 
     # Evolve 9.3.0 assumes this key is present in cmdutil.tryimportone()
     opts[b'obsolete'] = False
 
+    if ui.configbool(b'phabimport', b'secret'):
+        opts[b'secret'] = True
+
     def _write(patches):
         parents = repo[None].parents()