Submitter | phabricator |
---|---|
Date | March 6, 2020, 10:19 a.m. |
Message ID | <differential-rev-PHID-DREV-uf57zsb7muhsvpecrgqf-req@mercurial-scm.org> |
Download | mbox | patch |
Permalink | /patch/45537/ |
State | Superseded |
Headers | show |
Comments
pulkit added a comment. Forgot to mention, I tried to apply this patch on default and it failed. Now I see it's targeted for stable. Since most of the rust code is experimental/not much used, it should be fine to have this on default branch. Any reason why this is targeted for stable? REPOSITORY rHG Mercurial BRANCH stable CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D8246/new/ REVISION DETAIL https://phab.mercurial-scm.org/D8246 To: Alphare, #hg-reviewers, pulkit Cc: mercurial-devel
Alphare added a comment. In D8246#123554 <https://phab.mercurial-scm.org/D8246#123554>, @yuja wrote: >> +/// Remove this to see (potential) non-artificial compile failures. MacOS >> +/// *should* compile, but fail to compile tests for example as of 2020-03-06 > > Un-doccommented this to silence build warning. Thanks, good catch. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D8246/new/ REVISION DETAIL https://phab.mercurial-scm.org/D8246 To: Alphare, #hg-reviewers, pulkit Cc: yuja, mercurial-devel
Patch
diff --git a/rust/hg-core/src/lib.rs b/rust/hg-core/src/lib.rs --- a/rust/hg-core/src/lib.rs +++ b/rust/hg-core/src/lib.rs @@ -23,6 +23,14 @@ pub use revlog::*; pub mod utils; +/// Remove this to see (potential) non-artificial compile failures. MacOS +/// *should* compile, but fail to compile tests for example as of 2020-03-06 +#[cfg(not(target_os = "linux"))] +compile_error!( + "`hg-core` has only been tested on Linux and will most \ + likely not behave correctly on other platforms." +); + use crate::utils::hg_path::HgPathBuf; pub use filepatterns::{ build_single_regex, read_pattern_file, PatternSyntax, PatternTuple,