Patchwork D8219: phabricator: rename a variable to clarify that it is the parent filecontext

login
register
mail settings
Submitter phabricator
Date March 4, 2020, 7:07 p.m.
Message ID <d784427aed73eae0606e80275a79c2bc@localhost.localdomain>
Download mbox | patch
Permalink /patch/45478/
State Not Applicable
Headers show

Comments

phabricator - March 4, 2020, 7:07 p.m.
Closed by commit rHGaa9979bb6853: phabricator: rename a variable to clarify that it is the parent filecontext (authored by mharbison72).
This revision was automatically updated to reflect the committed changes.
This revision was not accepted when it landed; it landed in state "Needs Review".

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST UPDATE
  https://phab.mercurial-scm.org/D8219?vs=20467&id=20481

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D8219/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D8219

AFFECTED FILES
  hgext/phabricator.py

CHANGE DETAILS




To: mharbison72, #hg-reviewers
Cc: Kwan, mercurial-devel

Patch

diff --git a/hgext/phabricator.py b/hgext/phabricator.py
--- a/hgext/phabricator.py
+++ b/hgext/phabricator.py
@@ -814,8 +814,8 @@ 
             currentPath=fname, oldPath=fname, type=DiffChangeType.DELETE
         )
         pchange.addoldmode(gitmode[ctx.p1()[fname].flags()])
-        fctx = ctx.p1()[fname]
-        if not (fctx.isbinary() or notutf8(fctx)):
+        oldfctx = ctx.p1()[fname]
+        if not (oldfctx.isbinary() or notutf8(oldfctx)):
             maketext(pchange, ctx, fname)
 
         pdiff.addchange(pchange)