Patchwork D8178: heptapod-ci: also run some test for chg

login
register
mail settings
Submitter phabricator
Date Feb. 28, 2020, 1:25 p.m.
Message ID <differential-rev-PHID-DREV-jdnm5dukyl2grwixccx4-req@mercurial-scm.org>
Download mbox | patch
Permalink /patch/45379/
State Superseded
Headers show

Comments

phabricator - Feb. 28, 2020, 1:25 p.m.
marmoute created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.

REVISION SUMMARY
  I am not are of any regular effort to run test with chg. So let's at least do it
  here.

REPOSITORY
  rHG Mercurial

BRANCH
  stable

REVISION DETAIL
  https://phab.mercurial-scm.org/D8178

AFFECTED FILES
  contrib/heptapod-ci.yml

CHANGE DETAILS




To: marmoute, #hg-reviewers
Cc: mercurial-devel
phabricator - Feb. 28, 2020, 1:52 p.m.
pulkit added a comment.


  Any reason why py3-chg is not included?

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D8178/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D8178

To: marmoute, #hg-reviewers
Cc: pulkit, mercurial-devel
phabricator - Feb. 28, 2020, 2:09 p.m.
marmoute added a comment.
marmoute abandoned this revision.


  how did this go on phabricator… (probably runing phabsend with the wrong hash)

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D8178/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D8178

To: marmoute, #hg-reviewers
Cc: pulkit, mercurial-devel
phabricator - Feb. 28, 2020, 2:09 p.m.
marmoute added a comment.


  abandonning this for now. I mostly wanted to see a run on heptapod (spoiler warning about 20 test are broken)

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D8178/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D8178

To: marmoute, #hg-reviewers
Cc: pulkit, mercurial-devel
phabricator - April 2, 2020, 4:18 p.m.
marmoute added a comment.


  Is this targetted for stable or default ? having it on stable would be nice.

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D8178/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D8178

To: marmoute, #hg-reviewers
Cc: pulkit, mercurial-devel
phabricator - April 2, 2020, 4:26 p.m.
pulkit added a comment.


  In D8178#124930 <https://phab.mercurial-scm.org/D8178#124930>, @marmoute wrote:
  
  > Is this targetted for stable or default ? having it on stable would be nice.
  
  Since all the fixes are on default branch, I am targeting it for default. Also default will be merged in stable after couple of weeks for release candidate, so we will have it in stable soon.

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D8178/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D8178

To: marmoute, #hg-reviewers
Cc: pulkit, mercurial-devel
phabricator - April 2, 2020, 4:59 p.m.
marmoute added a comment.


  Can we get the fix grafted on the stable branches. There are people using chg in production that would need them.

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D8178/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D8178

To: marmoute, #hg-reviewers
Cc: pulkit, mercurial-devel
phabricator - April 3, 2020, 9:23 a.m.
pulkit added a comment.


  In D8178#124932 <https://phab.mercurial-scm.org/D8178#124932>, @marmoute wrote:
  
  > Can we get the fix grafted on the stable branches. There are people using chg in production that would need them.
  
  I don't have a strong opinion here because I feel fixes are minor.

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D8178/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D8178

To: marmoute, #hg-reviewers
Cc: pulkit, mercurial-devel
phabricator - April 13, 2020, 1:57 p.m.
pulkit added a comment.


  Gentle review ping. Since, we are going to cut a RC this week, let's push this to default. Also for reviewers, the patch is still authored by @marmoute, I just rebased and updated after my chg fixes got in.

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D8178/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D8178

To: marmoute, #hg-reviewers
Cc: pulkit, mercurial-devel
phabricator - April 15, 2020, 6:27 p.m.
marmoute added a comment.


  I wanted to make it accepted, but apparently I am flag as owner…
  
  So this looks good to me. As followup we could have the same for pure and rust (probably starting with manual triggering to avoid CI load explosion).
  
  What's the latest of having this for python3 ? it would be nice to have chg well covered there too.

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D8178/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D8178

To: marmoute, #hg-reviewers
Cc: pulkit, mercurial-devel
phabricator - April 22, 2020, 4:14 p.m.
Herald added a subscriber: mercurial-patches.
marmoute added a comment.


  Gentle ping, it would be nice to have this on stable.

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D8178/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D8178

To: marmoute, #hg-reviewers
Cc: mercurial-patches, pulkit, mercurial-devel

Patch

diff --git a/contrib/heptapod-ci.yml b/contrib/heptapod-ci.yml
--- a/contrib/heptapod-ci.yml
+++ b/contrib/heptapod-ci.yml
@@ -73,3 +73,8 @@ 
         HGWITHRUSTEXT: cpython
         RUNTEST_ARGS: "--blacklist /tmp/check-tests.txt"
         PYTHON: python3
+
+test-py2-chg:
+    <<: *runtests
+    variables:
+        RUNTEST_ARGS: "--blacklist /tmp/check-tests.txt --chg"