Patchwork D8144: tests: stabilize test-amend.t on Windows

login
register
mail settings
Submitter phabricator
Date Feb. 24, 2020, 9:39 p.m.
Message ID <differential-rev-PHID-DREV-yowcgqdoxtu4br2fd6v6-req@mercurial-scm.org>
Download mbox | patch
Permalink /patch/45305/
State Superseded
Headers show

Comments

phabricator - Feb. 24, 2020, 9:39 p.m.
mharbison72 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.

REVISION SUMMARY
  If $TESTTMP isn't quoted in this context, it ends up like
  `C:Temphgtests.pikkoxchild1test-amend.t-obsstore-off`.

REPOSITORY
  rHG Mercurial

BRANCH
  stable

REVISION DETAIL
  https://phab.mercurial-scm.org/D8144

AFFECTED FILES
  tests/test-amend.t

CHANGE DETAILS




To: mharbison72, #hg-reviewers
Cc: mercurial-devel
phabricator - Feb. 24, 2020, 9:54 p.m.
mharbison72 added a comment.


  This is meant for stable.  The other test fixes I'll submit shortly are for default.

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D8144/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D8144

To: mharbison72, #hg-reviewers
Cc: mercurial-devel

Patch

diff --git a/tests/test-amend.t b/tests/test-amend.t
--- a/tests/test-amend.t
+++ b/tests/test-amend.t
@@ -487,7 +487,7 @@ 
   $ echo beta >> foo
   $ cat > $TESTTMP/touchy_editor.sh <<EOF
   > sleep 1
-  > echo delta >> $TESTTMP/modify-during-amend/foo
+  > echo delta >> "$TESTTMP/modify-during-amend/foo"
   > sleep 1
   > echo hi > "\$1"
   > sleep 1