Patchwork D8099: lfs: use str for the open() mode when opening a blob for py3

login
register
mail settings
Submitter phabricator
Date Feb. 10, 2020, 10:01 p.m.
Message ID <78907e684044c8604b08106acb0525d8@localhost.localdomain>
Download mbox | patch
Permalink /patch/45085/
State Not Applicable
Headers show

Comments

phabricator - Feb. 10, 2020, 10:01 p.m.
Closed by commit rHG234001d22ba6: lfs: use str for the open() mode when opening a blob for py3 (authored by mharbison72).
This revision was automatically updated to reflect the committed changes.
This revision was not accepted when it landed; it landed in state "Needs Review".

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST UPDATE
  https://phab.mercurial-scm.org/D8099?vs=20032&id=20062

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D8099/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D8099

AFFECTED FILES
  hgext/lfs/blobstore.py

CHANGE DETAILS




To: mharbison72, #hg-reviewers, pulkit, durin42
Cc: durin42, mercurial-devel

Patch

diff --git a/hgext/lfs/blobstore.py b/hgext/lfs/blobstore.py
--- a/hgext/lfs/blobstore.py
+++ b/hgext/lfs/blobstore.py
@@ -128,7 +128,7 @@ 
     def open(self, oid):
         """Open a read-only file descriptor to the named blob, in either the
         usercache or the local store."""
-        return open(self.path(oid), b'rb')
+        return open(self.path(oid), 'rb')
 
     def path(self, oid):
         """Build the path for the given blob ``oid``.