Patchwork D8083: archival: use walk() instead of matches() on manifest

login
register
mail settings
Submitter phabricator
Date Feb. 6, 2020, 4:11 p.m.
Message ID <a9f2fbd2212446ac46db4d18bdf874d1@localhost.localdomain>
Download mbox | patch
Permalink /patch/44991/
State Not Applicable
Headers show

Comments

phabricator - Feb. 6, 2020, 4:11 p.m.
Closed by commit rHG2d1b2ad3705b: archival: use walk() instead of matches() on manifest (authored by durin42).
This revision was automatically updated to reflect the committed changes.
This revision was not accepted when it landed; it landed in state "Needs Review".

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST UPDATE
  https://phab.mercurial-scm.org/D8083?vs=19926&id=19952

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D8083/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D8083

AFFECTED FILES
  mercurial/archival.py

CHANGE DETAILS




To: durin42, #hg-reviewers
Cc: mercurial-devel

Patch

diff --git a/mercurial/archival.py b/mercurial/archival.py
--- a/mercurial/archival.py
+++ b/mercurial/archival.py
@@ -355,7 +355,7 @@ 
         if match(name):
             write(name, 0o644, False, lambda: buildmetadata(ctx))
 
-    files = [f for f in ctx.manifest().matches(match)]
+    files = list(ctx.manifest().walk(match))
     total = len(files)
     if total:
         files.sort()