Patchwork D8055: absorb: graduate -i flag from experimental

login
register
mail settings
Submitter phabricator
Date Jan. 31, 2020, 5:26 p.m.
Message ID <differential-rev-PHID-DREV-ncs72fr2iuwfytt74tn2-req@mercurial-scm.org>
Download mbox | patch
Permalink /patch/44826/
State Superseded
Headers show

Comments

phabricator - Jan. 31, 2020, 5:26 p.m.
martinvonz created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.

REVISION SUMMARY
  The interactive mode seems to work well. I have previously thought
  that `-i` should be what `-e` does, but the current behavior matches
  what other `-i` flags do (select a subset of the hunks), so I think
  that is what we want.

REPOSITORY
  rHG Mercurial

BRANCH
  default

REVISION DETAIL
  https://phab.mercurial-scm.org/D8055

AFFECTED FILES
  hgext/absorb.py

CHANGE DETAILS




To: martinvonz, #hg-reviewers
Cc: mercurial-devel
phabricator - Jan. 31, 2020, 11:31 p.m.
This revision is now accepted and ready to land.
pulkit added a comment.
pulkit accepted this revision.


  The whole absorb extension is experimental, so even if we want to change `-i` somehow in future, this looks fine.

REPOSITORY
  rHG Mercurial

BRANCH
  default

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D8055/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D8055

To: martinvonz, #hg-reviewers, pulkit
Cc: pulkit, mercurial-devel

Patch

diff --git a/hgext/absorb.py b/hgext/absorb.py
--- a/hgext/absorb.py
+++ b/hgext/absorb.py
@@ -1077,7 +1077,7 @@ 
             b'i',
             b'interactive',
             None,
-            _(b'interactively select which chunks to apply (EXPERIMENTAL)'),
+            _(b'interactively select which chunks to apply'),
         ),
         (
             b'e',