Patchwork D8053: pyoxidizer: use `legacy_windows_stdio` on Windows

login
register
mail settings
Submitter phabricator
Date Jan. 31, 2020, 12:56 a.m.
Message ID <differential-rev-PHID-DREV-pptkfzywletevjoekvlp-req@mercurial-scm.org>
Download mbox | patch
Permalink /patch/44796/
State Superseded
Headers show

Comments

phabricator - Jan. 31, 2020, 12:56 a.m.
mharbison72 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.

REVISION SUMMARY
  The C executable sets this too, otherwise no output shows up (when paging?).
  There is also `legacy_windows_fs_encoding`, but I'm not setting that for now
  because the C executable doesn't either.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D8053

AFFECTED FILES
  contrib/packaging/pyoxidizer.bzl

CHANGE DETAILS




To: mharbison72, #hg-reviewers
Cc: mercurial-devel
phabricator - Feb. 7, 2020, 6:41 p.m.
marmoute added a comment.
marmoute accepted this revision.


  I guess this is right ? We hase have similar fallback to legacy mode in the python code.

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D8053/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D8053

To: mharbison72, #hg-reviewers, marmoute
Cc: marmoute, mercurial-devel

Patch

diff --git a/contrib/packaging/pyoxidizer.bzl b/contrib/packaging/pyoxidizer.bzl
--- a/contrib/packaging/pyoxidizer.bzl
+++ b/contrib/packaging/pyoxidizer.bzl
@@ -23,6 +23,7 @@ 
         run_eval = code,
         # We need this to make resourceutil happy, since it looks for sys.frozen.
         sys_frozen = True,
+        legacy_windows_stdio = True,
     )
 
     exe = dist.to_python_executable(