Patchwork D8050: rust-dirstatemap: update call sites from Python

login
register
mail settings
Submitter phabricator
Date Jan. 30, 2020, 2:10 p.m.
Message ID <differential-rev-PHID-DREV-f66kej3ilcqzsiwvdiap-req@mercurial-scm.org>
Download mbox | patch
Permalink /patch/44773/
State Superseded
Headers show

Comments

phabricator - Jan. 30, 2020, 2:10 p.m.
Alphare created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.

REPOSITORY
  rHG Mercurial

BRANCH
  stable

REVISION DETAIL
  https://phab.mercurial-scm.org/D8050

AFFECTED FILES
  mercurial/dirstate.py

CHANGE DETAILS




To: Alphare, #hg-reviewers
Cc: mercurial-devel
phabricator - Feb. 7, 2020, 8:14 p.m.
This revision now requires changes to proceed.
marmoute added a comment.
marmoute requested changes to this revision.


  This is straightforward, however having some performance number would be great.

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D8050/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D8050

To: Alphare, #hg-reviewers, marmoute
Cc: marmoute, mercurial-devel
phabricator - Feb. 10, 2020, 3:54 p.m.
Alphare added a comment.


  In D8050#119795 <https://phab.mercurial-scm.org/D8050#119795>, @marmoute wrote:
  
  > This is straightforward, however having some performance number would be great.
  
  This is simply an API change related to the performance improvements in previous patches. Is this commit where we should put those performance numbers?

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D8050/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D8050

To: Alphare, #hg-reviewers, marmoute
Cc: marmoute, mercurial-devel
phabricator - Feb. 10, 2020, 6:01 p.m.
pulkit added a comment.


  In D8050#120043 <https://phab.mercurial-scm.org/D8050#120043>, @Alphare wrote:
  
  > In D8050#119795 <https://phab.mercurial-scm.org/D8050#119795>, @marmoute wrote:
  >
  >> This is straightforward, however having some performance number would be great.
  >
  > This is simply an API change related to the performance improvements in previous patches. Is this commit where we should put those performance numbers?
  
  Yes, it's fine to put performance numbers in last patch in series.
  
  Also these changes should ideally be folded into patches where corresponding rust changes are done.

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D8050/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D8050

To: Alphare, #hg-reviewers, marmoute
Cc: pulkit, marmoute, mercurial-devel
phabricator - Feb. 10, 2020, 9:11 p.m.
Alphare added a comment.
Alphare abandoned this revision.


  Folded into the previous changeset, with an amended commit message

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D8050/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D8050

To: Alphare, #hg-reviewers, marmoute
Cc: pulkit, marmoute, mercurial-devel

Patch

diff --git a/mercurial/dirstate.py b/mercurial/dirstate.py
--- a/mercurial/dirstate.py
+++ b/mercurial/dirstate.py
@@ -1846,12 +1846,12 @@ 
 
         @property
         def nonnormalset(self):
-            nonnorm, otherparents = self._rustmap.nonnormalentries()
+            nonnorm = self._rustmap.non_normal_entries()
             return nonnorm
 
         @propertycache
         def otherparentset(self):
-            nonnorm, otherparents = self._rustmap.nonnormalentries()
+            otherparents = self._rustmap.other_parent_entries()
             return otherparents
 
         @propertycache