Patchwork D7973: packaging: add configparser to inno requirements file

login
register
mail settings
Submitter phabricator
Date Jan. 23, 2020, 4:03 a.m.
Message ID <differential-rev-PHID-DREV-ecslpz22v63pwiw7smju-req@mercurial-scm.org>
Download mbox | patch
Permalink /patch/44581/
State Superseded
Headers show

Comments

phabricator - Jan. 23, 2020, 4:03 a.m.
indygreg created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.

REVISION SUMMARY
  This dependency is missing and pip complains about it in
  strict hashing mode. How this was missed, I have no clue.

REPOSITORY
  rHG Mercurial

BRANCH
  stable

REVISION DETAIL
  https://phab.mercurial-scm.org/D7973

AFFECTED FILES
  contrib/packaging/inno/requirements.txt

CHANGE DETAILS




To: indygreg, #hg-reviewers
Cc: mercurial-devel
phabricator - Jan. 24, 2020, 3:04 p.m.
mharbison72 added a comment.


  This is needed on stable to be able to build the Inno installer there.

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D7973/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D7973

To: indygreg, #hg-reviewers, pulkit
Cc: mharbison72, mercurial-devel
phabricator - Jan. 25, 2020, 3:22 a.m.
indygreg added a comment.


  Yeah, it was flagged as stable in the branch metadata. But whoever queued it didn't see that. (Perhaps we should improve `hg phabread` to warn on branch name mismatch?)
  
  I'll manually queue this for stable.

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D7973/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D7973

To: indygreg, #hg-reviewers, pulkit
Cc: mharbison72, mercurial-devel
phabricator - Jan. 25, 2020, 3:41 a.m.
mharbison72 added a comment.


  In D7973#117958 <https://phab.mercurial-scm.org/D7973#117958>, @indygreg wrote:
  
  > Yeah, it was flagged as stable in the branch metadata. But whoever queued it didn't see that. (Perhaps we should improve `hg phabread` to warn on branch name mismatch?)
  > I'll manually queue this for stable.
  
  I'd be interested in something like this.  But we've got more than default and stable at work, so it might need to be on the `import` side?  The `--exact` parameter won't generally work because e.g. the amend entry in extras doesn't get carried in the patch, so that would fail to apply entirely.  So it would need to be something like `--exact-parent`, which probably isn't as useful for Mercurial reviewers.  Coupled with `--bypass`, you don't really need to be on the correct branch, I don't think.  But it all seems like a related problem.

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D7973/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D7973

To: indygreg, #hg-reviewers, pulkit
Cc: mharbison72, mercurial-devel

Patch

diff --git a/contrib/packaging/inno/requirements.txt b/contrib/packaging/inno/requirements.txt
--- a/contrib/packaging/inno/requirements.txt
+++ b/contrib/packaging/inno/requirements.txt
@@ -8,6 +8,10 @@ 
     --hash=sha256:e4f3620cfea4f83eedc95b24abd9cd56f3c4b146dd0177e83a21b4eb49e21e50 \
     --hash=sha256:fd7c7c74727ddcf00e9acd26bba8da604ffec95bf1c2144e67aff7a8b50e6cef \
     # via dulwich
+configparser==4.0.2 \
+    --hash=sha256:254c1d9c79f60c45dfde850850883d5aaa7f19a23f13561243a050d5a7c3fe4c \
+    --hash=sha256:c7d282687a5308319bf3d2e7706e575c635b0a470342641c93bea0ea3b5331df \
+    # via entrypoints
 docutils==0.15.2 \
     --hash=sha256:6c4f696463b79f1fb8ba0c594b63840ebd41f059e92b31957c46b74a4599b6d0 \
     --hash=sha256:9e4d7ecfc600058e07ba661411a2b7de2fd0fafa17d1a7f7361cd47b1175c827 \
@@ -34,8 +38,7 @@ 
     --hash=sha256:881c4c157e45f30af185c1ffe8d549d48ac9127433f2c380c24b84572ad66297
 pywin32-ctypes==0.2.0 \
     --hash=sha256:24ffc3b341d457d48e8922352130cf2644024a4ff09762a2261fd34c36ee5942 \
-    --hash=sha256:9dc2d991b3479cc2df15930958b674a48a227d5361d413827a4cfd0b5876fc98 \
-    # via keyring
+    --hash=sha256:9dc2d991b3479cc2df15930958b674a48a227d5361d413827a4cfd0b5876fc98
 urllib3==1.25.6 \
     --hash=sha256:3de946ffbed6e6746608990594d08faac602528ac7015ac28d33cee6a45b7398 \
     --hash=sha256:9a107b99a5393caf59c7aa3c1249c16e6879447533d0887f4336dde834c7be86 \