Submitter | phabricator |
---|---|
Date | Jan. 18, 2020, 9:18 p.m. |
Message ID | <differential-rev-PHID-DREV-xbpzixrbzyyqzds66knr-req@mercurial-scm.org> |
Download | mbox | patch |
Permalink | /patch/44523/ |
State | Superseded |
Headers | show |
Comments
marmoute added a comment. marmoute accepted this revision. urg… REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7944/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7944 To: indygreg, #hg-reviewers, marmoute Cc: marmoute, mercurial-devel
Herald added a subscriber: mercurial-patches. This revision now requires changes to proceed. baymax added a comment. baymax requested changes to this revision. There seems to have been no activities on this Diff for the past 3 Months. By policy, we are automatically moving it out of the `need-review` state. Please, move it back to `need-review` without hesitation if this diff should still be discussed. :baymax:need-review-idle: REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7944/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7944 To: indygreg, #hg-reviewers, marmoute, baymax Cc: mercurial-patches, marmoute, mercurial-devel
marmoute added a comment. This patch is still correct, not sure why it is not it yet. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7944/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7944 To: indygreg, #hg-reviewers, marmoute, baymax Cc: mercurial-patches, marmoute, mercurial-devel
Patch
diff --git a/mercurial/localrepo.py b/mercurial/localrepo.py --- a/mercurial/localrepo.py +++ b/mercurial/localrepo.py @@ -504,6 +504,11 @@ except OSError as e: if e.errno != errno.ENOENT: raise + except ValueError as e: + # Can be raised on Python 3.8 when path is invalid. + raise error.Abort( + _(b'invalid path %s: %s') % (path, pycompat.bytestr(e)) + ) raise error.RepoError(_(b'repository %s not found') % path)