Patchwork D7768: commit: change default `editor` parameter to None

login
register
mail settings
Submitter phabricator
Date Jan. 8, 2020, 7:51 p.m.
Message ID <f8ed7e504b9ee38afac917b30d12828c@localhost.localdomain>
Download mbox | patch
Permalink /patch/44207/
State Not Applicable
Headers show

Comments

phabricator - Jan. 8, 2020, 7:51 p.m.
Closed by commit rHG3216cabffd4a: commit: change default `editor` parameter to None (authored by mharbison72).
This revision was automatically updated to reflect the committed changes.
This revision was not accepted when it landed; it landed in state "Needs Review".

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST UPDATE
  https://phab.mercurial-scm.org/D7768?vs=18999&id=19097

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D7768/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D7768

AFFECTED FILES
  mercurial/context.py
  mercurial/localrepo.py

CHANGE DETAILS




To: mharbison72, #hg-reviewers
Cc: mercurial-devel

Patch

diff --git a/mercurial/localrepo.py b/mercurial/localrepo.py
--- a/mercurial/localrepo.py
+++ b/mercurial/localrepo.py
@@ -2845,7 +2845,7 @@ 
         date=None,
         match=None,
         force=False,
-        editor=False,
+        editor=None,
         extra=None,
     ):
         """Add a new revision to current repository.
diff --git a/mercurial/context.py b/mercurial/context.py
--- a/mercurial/context.py
+++ b/mercurial/context.py
@@ -2738,7 +2738,7 @@ 
         date=None,
         extra=None,
         branch=None,
-        editor=False,
+        editor=None,
     ):
         super(memctx, self).__init__(
             repo, text, user, date, extra, branch=branch
@@ -2899,7 +2899,7 @@ 
         user=None,
         date=None,
         extra=None,
-        editor=False,
+        editor=None,
     ):
         if text is None:
             text = originalctx.description()