From patchwork Sat Dec 28 16:42:52 2019
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: D7769: tests: fix a copy/paste name duplication in storage.py
From: phabricator <phabricator@mercurial-scm.org>
X-Patchwork-Id: 44111
Message-Id: <differential-rev-PHID-DREV-fpdlzrjgbswmczxiyyrz-req@mercurial-scm.org>
To: Phabricator <phabricator@mercurial-scm.org>
Cc: mercurial-devel@mercurial-scm.org
Date: Sat, 28 Dec 2019 16:42:52 +0000

mharbison72 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.

REVISION SUMMARY
  Flagged by PyCharm as a redeclared name without usage, because the name matches
  the function immediately preceding it.  But since this differs by doing regular
  reads instead of raw reads, I assume we still want it.  But I don't see either
  function being called anywhere.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D7769

AFFECTED FILES
  mercurial/testing/storage.py

CHANGE DETAILS




To: mharbison72, #hg-reviewers
Cc: mercurial-devel

diff --git a/mercurial/testing/storage.py b/mercurial/testing/storage.py
--- a/mercurial/testing/storage.py
+++ b/mercurial/testing/storage.py
@@ -964,7 +964,7 @@
         with self.assertRaises(error.StorageError):
             f.rawdata(node1)
 
-    def testbadnoderevisionraw(self):
+    def testbadnoderevision(self):
         # Like above except we test read() first to isolate revision caching
         # behavior.
         f = self._makefilefn()