D7746: rebase: drop an unused variable assignment

Submitter	phabricator
Date	Dec. 27, 2019, 9:18 p.m.
Message ID	<differential-rev-PHID-DREV-pq54kbp2zgc4paepotb3-req@mercurial-scm.org>
Download	mbox \| patch
Permalink	/patch/44075/
State	Superseded
Headers	show Return-Path: <mercurial-devel-bounces@mercurial-scm.org> Date: Fri, 27 Dec 2019 21:18:08 +0000 To: Phabricator <phabricator@mercurial-scm.org> From: "mharbison72 (Matt Harbison)" <phabricator@mercurial-scm.org> Subject: D7746: rebase: drop an unused variable assignment Message-ID: <differential-rev-PHID-DREV-pq54kbp2zgc4paepotb3-req@mercurial-scm.org> Precedence: bulk Thread-Topic: PHID-DREV-pq54kbp2zgc4paepotb3 Thread-Index: YzA1Yzc4YTMxNzRlMjdjNzQ1ODdmMDI0ZTY3 MIME-Version: 1.0 Cc: mercurial-devel@mercurial-scm.org Reply-To: "mharbison72 \(Matt Harbison\)" <phabricator+D7746+public+1bbb62b9be8ee779@mercurial-scm.org> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: mercurial-devel-bounces@mercurial-scm.org Sender: "Mercurial-devel" <mercurial-devel-bounces@mercurial-scm.org>

Comments

phabricator - Dec. 27, 2019, 9:18 p.m.

mharbison72 created this revision.
Herald added a reviewer: martinvonz.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.

REVISION SUMMARY
  Caught by PyCharm.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D7746

AFFECTED FILES
  hgext/rebase.py

CHANGE DETAILS




To: mharbison72, martinvonz, #hg-reviewers
Cc: mercurial-devel

Patch

diff --git a/hgext/rebase.py b/hgext/rebase.py
--- a/hgext/rebase.py
+++ b/hgext/rebase.py
@@ -787,7 +787,6 @@ 
                 cleanup = False
 
             if cleanup:
-                shouldupdate = False
                 if rebased:
                     strippoints = [
                         c.node() for c in repo.set(b'roots(%ld)', rebased)

Patchwork D7746: rebase: drop an unused variable assignment

Comments

Patch