Patchwork D7729: py3: new attempt at fixing logging of traceback in remotefilelog

login
register
mail settings
Submitter phabricator
Date Dec. 27, 2019, 4:58 p.m.
Message ID <differential-rev-PHID-DREV-27i7fckljlhm46f7ayld-req@mercurial-scm.org>
Download mbox | patch
Permalink /patch/44051/
State Superseded
Headers show

Comments

phabricator - Dec. 27, 2019, 4:58 p.m.
martinvonz created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.

REVISION SUMMARY
  D7598 <https://phab.mercurial-scm.org/D7598> tried and seems to have failed because traceback.format_stack()
  returns a list, not a string.

REPOSITORY
  rHG Mercurial

BRANCH
  default

REVISION DETAIL
  https://phab.mercurial-scm.org/D7729

AFFECTED FILES
  hgext/remotefilelog/fileserverclient.py

CHANGE DETAILS




To: martinvonz, #hg-reviewers
Cc: mercurial-devel
phabricator - Jan. 3, 2020, 6:19 a.m.
martinvonz added a comment.
martinvonz abandoned this revision.


  Abandoning in favor of D7785 <https://phab.mercurial-scm.org/D7785>

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D7729/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D7729

To: martinvonz, #hg-reviewers
Cc: mercurial-devel

Patch

diff --git a/hgext/remotefilelog/fileserverclient.py b/hgext/remotefilelog/fileserverclient.py
--- a/hgext/remotefilelog/fileserverclient.py
+++ b/hgext/remotefilelog/fileserverclient.py
@@ -663,5 +663,5 @@ 
         self.ui.log(
             b'remotefilelog',
             b'excess remotefilelog fetching:\n%s\n',
-            b''.join(pycompat.sysbytes(traceback.format_stack())),
+            b''.join(map(pycompat.sysbytes, traceback.format_stack())),
         )