D7706: tests-pure: fixing test-parseindex2

Submitter	phabricator
Date	Dec. 20, 2019, 4:24 p.m.
Message ID	<differential-rev-PHID-DREV-h4vigt3bx6t4z3ojgqlm-req@mercurial-scm.org>
Download	mbox \| patch
Permalink	/patch/44011/
State	Superseded
Headers	show Return-Path: <mercurial-devel-bounces@mercurial-scm.org> Date: Fri, 20 Dec 2019 16:24:55 +0000 To: Phabricator <phabricator@mercurial-scm.org> From: "gracinet (Georges Racinet)" <phabricator@mercurial-scm.org> Subject: D7706: tests-pure: fixing test-parseindex2 Message-ID: <differential-rev-PHID-DREV-h4vigt3bx6t4z3ojgqlm-req@mercurial-scm.org> Precedence: bulk Thread-Topic: PHID-DREV-h4vigt3bx6t4z3ojgqlm Thread-Index: MjZhZTFkNGIwNjZlNmJjZDVhYmRkZWFjYWZm MIME-Version: 1.0 Cc: mercurial-devel@mercurial-scm.org Reply-To: "gracinet \(Georges Racinet\)" <phabricator+D7706+public+7834a47af1f8a125@mercurial-scm.org> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: mercurial-devel-bounces@mercurial-scm.org Sender: "Mercurial-devel" <mercurial-devel-bounces@mercurial-scm.org>

Comments

phabricator - Dec. 20, 2019, 4:24 p.m.

gracinet created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.

REVISION SUMMARY
  This is a followup to D7603 <https://phab.mercurial-scm.org/D7603> (49fa0b31ee1d <https://phab.mercurial-scm.org/rHG49fa0b31ee1d84c44eab951f36fb7386e3fced22>) which broke
  the tests for pure Python implementation. There are two
  divergences between pure and C implementations:
  
  - the pure implementation would accept only -1 as slice end, whereas C accepts both -1 and len(index)
  - in pure Python, `headrevs` is provided by revlog.py, not by the index.

REPOSITORY
  rHG Mercurial

BRANCH
  default

REVISION DETAIL
  https://phab.mercurial-scm.org/D7706

AFFECTED FILES
  tests/test-parseindex2.py

CHANGE DETAILS




To: gracinet, #hg-reviewers
Cc: mercurial-devel

phabricator - Dec. 20, 2019, 6:57 p.m.

gracinet added a comment.
gracinet abandoned this revision.


  Duplicate of 7707

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D7706/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D7706

To: gracinet, #hg-reviewers
Cc: mercurial-devel

Patch

diff --git a/tests/test-parseindex2.py b/tests/test-parseindex2.py
--- a/tests/test-parseindex2.py
+++ b/tests/test-parseindex2.py
@@ -267,11 +267,13 @@ 
         appendrev(6)
         self.assertEqual(len(index), 7)
 
-        del index[1:7]
+        del index[1:-1]
 
         # assertions that failed before correction
         self.assertEqual(len(index), 1)  # was 4
-        self.assertEqual(index.headrevs(), [0])  # gave ValueError
+        headrevs = getattr(index, 'headrevs', None)
+        if headrevs is not None:  # not implemented in pure
+            self.assertEqual(index.headrevs(), [0])  # gave ValueError
 
 
 if __name__ == '__main__':

Patchwork D7706: tests-pure: fixing test-parseindex2

Comments

Patch