Patchwork D7651: nodetree: simplify a conditionnal in shortesthexnodeidprefix

login
register
mail settings
Submitter phabricator
Date Dec. 19, 2019, 6:10 p.m.
Message ID <c37598bee960e2f11b32219a7d6d6a75@localhost.localdomain>
Download mbox | patch
Permalink /patch/43999/
State Not Applicable
Headers show

Comments

phabricator - Dec. 19, 2019, 6:10 p.m.
marmoute updated this revision to Diff 18886.

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST UPDATE
  https://phab.mercurial-scm.org/D7651?vs=18806&id=18886

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D7651/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D7651

AFFECTED FILES
  mercurial/scmutil.py

CHANGE DETAILS




To: marmoute, #hg-reviewers, pulkit
Cc: mercurial-devel

Patch

diff --git a/mercurial/scmutil.py b/mercurial/scmutil.py
--- a/mercurial/scmutil.py
+++ b/mercurial/scmutil.py
@@ -545,12 +545,10 @@ 
             if cache is not None:
                 nodetree = cache.get(b'disambiguationnodetree')
             if not nodetree:
-                try:
+                if util.safehasattr(parsers, 'nodetree'):
+                    # The CExt is the only implementation to provide a nodetree
+                    # class so far.
                     nodetree = parsers.nodetree(cl.index, len(revs))
-                except AttributeError:
-                    # no native nodetree
-                    pass
-                else:
                     for r in revs:
                         nodetree.insert(r)
                     if cache is not None: